WM5 | Karam Ali | Bikes For Refugees | Week 1 #461
Conversation
✅ Deploy Preview for cyf-bfr ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Fab work, Karam!! ⭐
Thanks so much for your hard work on this. I've dropped a few comments and asked a few questions. You might find this article interesting https://css-tricks.com/magic-numbers-in-css/
index.html
Outdated
| <header class="header"> | ||
| <a href="#"> | ||
| <img | ||
| src="/bikes-for-refugees/images/bikes-for-refugees_logo.jpg" |
There was a problem hiding this comment.
When you checked your work in the deploy preview, what showed up here?
Is this path working?
There was a problem hiding this comment.
Hi sorry I had a issue when pushing css file to my branch
|
|
||
| .volunteer-btn { |
There was a problem hiding this comment.
Do you need to repeat all these styles again? What does class mean?
Can you make a class for all buttons, and then just set rules for the variations?
styles/style.css
Outdated
| @@ -120,8 +161,16 @@ p { | |||
| /* hero */ | |||
|
|
|||
| .hero { | |||
| background-image: url("header-bike.jpg"); | |||
| background-image: url("/bikes-for-refugees/images/header-bike.jpg"); | |||
There was a problem hiding this comment.
Is this path correct? Where is this image relative to this stylesheet?
| height: 58%; | ||
| background-size: auto; | ||
| color: white; | ||
| padding-left: 4.4%; |
There was a problem hiding this comment.
This seems a bit like a kind of "eyeball" number or "magic number". What made you decide on 58% and 4.4%?
| .footer_content { | ||
| margin-top: 10.8rem; | ||
| border-top: 2px solid var(--orange-light); | ||
| width: 76%; |
Completed version Bike for Refugees.
Much appreciated for any comments or feedback