Dynamic page titles #503
Dynamic page titles #503
Conversation
dschwindt
requested review from
jacobvenable,
jollyjerr and
rhinodavid
as code owners
|
馃懛 Deploy request for upswyng accepted. 馃敤 Explore the source changes: 2bf51fe 馃攳 Inspect the deploy log: https://app.netlify.com/sites/upswyng/deploys/619bc578ef736a0007887a67 |
| @@ -51,6 +52,9 @@ const CategoryResults = ({ | |||
|
|
|||
| return ( | |||
| <> | |||
| <Helmet> | |||
| <title>{t(categoryTranslationKey)} - Upswyng</title> | |||
There was a problem hiding this comment.
Thoughts on creating a utility that centralized appending the "- UpSwyng" to the title? Could create something like seo.js in the utils folder and create a makePageTitle that accepts a string as an argument and just returns that appended with - UpSwyng.
| import HomeButtons from "./HomeButtons"; | ||
| import React from "react"; | ||
| import SearchForm from "./SearchForm"; | ||
| import { useTranslation } from "react-i18next"; | ||
|
|
||
| const Home = () => { | ||
| const { t } = useTranslation("footer"); | ||
| const { t } = useTranslation(["footer", "home"]); |
There was a problem hiding this comment.
Another options could be removing the specific name space here and just applying it within the t function, e.g.:
const { t } = useTranslation();
// ...other stuff in between
<Helmet>
<title>{t("home.title")}</title>
<meta name="description" content={t("home.description")} />
</Helmet>NBD either way but thought this may be a bit easier to read.
|
Looking good! I think we should try to add a utility that automatically appends |
|
鈩癸笍 Heads up to anyone who stumbles on this PR. I was made aware that this developer won't be able to finish this ticket and will be taking on my minor nits. I appreciate @dschwindt for getting it this far! |
This PR closes #501
What does this PR do?
When a user navigates to a different page on the site, this code dynamically updates the page titles in English and Spanish using react-helmet and react-i18next so that the titles can be reflected in analytics. The code also includes a description for the home page for SEO in both languages.
How does this PR make you feel? 馃敆