I18n spanish 450 #457
Merged
I18n spanish 450 #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paspheeris
requested review from
jacobvenable,
jollyjerr and
rhinodavid
as code owners
|
Deploy request for upswyng accepted. Accepted with commit 3a82fc2 https://app.netlify.com/sites/upswyng/deploys/6060afbd7f55d900073d1e60 |
| @@ -287,6 +289,7 @@ const Map = ({ address, name, latitude, longitude }: Props) => { | |||
| <IconButton | |||
| onClick={() => handleDirectionButtonClick("TRANSIT")} | |||
| color={travelMode === "TRANSIT" ? "primary" : "default"} | |||
| title={t("directionsByBus")} | |||
There was a problem hiding this comment.
Def good call on adding these!
Comment on lines
132
to
136
| <PhoneIcon titleAccess={t("phoneNumber")} /> | ||
| </ListItemIcon> | ||
| <ListItemText> | ||
| <Typography component="h2" variant="srOnly"> | ||
| Phone | ||
| {t("phoneNumber")} |
There was a problem hiding this comment.
I like your thinking here, but in this case I don't think we need to have the title on the icon. The srOnly variant of the following heading sets this as hidden text that is available to screen readers.
Adding a title to the icon as well means a SR would read "phone number" twice.
There was a problem hiding this comment.
Good point! f4948d9
jollyjerr
approved these changes
Mar 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #450
What does this PR do?
Adds Spanish translations for the individual resource page.
Remarks:
-I added the
titleAccessprop for the icons even though there'ssrOnlytext for them, because I think that's what's recommended by the material-ui docs and what I read elsewhere. I really need to educate myself on a11y issues better 馃槥-For the schedule section, I was able to provide translations for resources that display a
WeeklySchedule, but theMonthlyScheduleis more problematic. Therrulelibrary's support for i18n is pretty basic, only allowing you to provide word-for-word translations and not accounting for eg word order differences between languages. I'm not sure what a good solution would be here.How does this PR make you feel? 馃敆
馃嚚馃嚧