Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add slides for @daffl's talks #5

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

daffl
Copy link

@daffl daffl commented Apr 26, 2018

No description provided.

@trueskawka
Copy link
Contributor

Hi @daffl - thanks for adding the resources! And for the awesome talks :)

Would you mind adjusting your resources for the NLP talk? It currently uses .less, so it's not out of the box "open this html file".

The easiest way to make sure the slides are easily readable is to export them to .pdf, if you have the time, but I think just generating the .css is also fine. Or, if you prefer, adding a README.md with info on how to run the build.

Thanks!

@daffl
Copy link
Author

daffl commented Apr 26, 2018

Thanks @trueskawka, I removed the build assets as they were actually not being used. Since some of slides are interactive they unfortunately won't work very well as PDFs.

It should be possible to publish the slides on GitHub pages though to make them more easily viewable. Maybe even moving master to gh-pages and creating an index page with links to each talks' HTML or PDF.

@trueskawka
Copy link
Contributor

Thanks @daffl!

It might me my setup, but when I fetched your PR and opened index.html for the NLP talk, I was missing assets. Traceback from developer tools:

fonts.googleapis.com/css?family=Muli:400,400italic Failed to load resource: net::ERR_FILE_NOT_FOUND
maxcdn.bootstrapcdn.com/font-awesome/4.3.0/css/font-awesome.min.css Failed to load resource: net::ERR_FILE_NOT_FOUND
dist/styles.css Failed to load resource: net::ERR_FILE_NOT_FOUND
nina.js Failed to load resource: net::ERR_FILE_NOT_FOUND

Am I missing something?

I'll look into making a website for the repository - I wonder how well it will work with .pdf slides other speakers submitted. Thanks for the suggestion!

@daffl
Copy link
Author

daffl commented Apr 27, 2018

Ah, they were relative URLs and I looked at it only through a webserver. The links should be fixed now as well 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants