Convert the iso8601 tool to use formatted output #3459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds XML support as well, which is somewhat pointless since this program doesn't really see a lot of use, but it's consistent with the rest of our command line tools. Additionally, here the XML output uses text nodes instead of putting everything into attributes. This is because the tool can potentially output multiple messages, one after the other. We never have all the data we need at once, so using text nodes is a cleaner way to structure the code. Fixes T109
clumens
force-pushed
the
iso8601
branch
2 times, most recently
from
1a3118f
to
089f5f7
Compare
Now that we have a program whose name does not begin with crm_ doing XML output, we need to update the regex to fix up the request= attribute.
kgaillot
approved these changes
May 20, 2024
|
If you want to get this in 2.1.8, backport it to the 2.1 branch |
I don't really care one way or another. I don't think anyone uses it, so it's really just for consistency with all our other stuff. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.