simplify code in utility/parseArguments #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sreeram-dev
changed the title
|
So the clients have to use 8000 port for the their primary webservers. The reason this nano - webserver is used is for OAuth 2.0 authentication. After the authentication is done on the web-browser, there is a redirect step for which I have to mention a fixed IP in the "Dropbox/Google" App setting. I have fixed it as localhost:8000. Authentication with a python API by not giving away app's secret key is far from trivial and this is why we needed such a solution. |
| self.maxim = int(complete_data['maxim']) | ||
| self.data = complete_data.get('config') | ||
| self.maxim = int(complete_data.get('maxim')) | ||
| self.server_port = int(complete_data.get('server_port')) |
There was a problem hiding this comment.
Why is 'exec' parameters? If you notice in config.json.example - there is a 'exec' parameter.
sreeram-dev
changed the title
|
@dexter1691 Any suggestions? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code base has nested try catch and redundant code. I did not change anything drastically. Many clients may use 8000 port for their primary webservers. CloudCV can be a part of bigger setup. We should give users the choose on which port they want to run the server.