Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added command to display contents of stdderr file #255

Open
wants to merge 20 commits into
base: master
Choose a base branch
from
Open

Added command to display contents of stdderr file #255

wants to merge 20 commits into from

Conversation

jayaike
Copy link
Contributor

@jayaike jayaike commented Jan 12, 2020

I have added a command to display the contents of the stderr file

It is invoked by running evalai submission SUBMISSION_ID stderr

Copy link
Member

@krtkvrm krtkvrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add tests

@jayaike
Copy link
Contributor Author

jayaike commented Jan 12, 2020

@vkartik97 Alright

@jayaike
Copy link
Contributor Author

jayaike commented Jan 12, 2020

See screenshot
Screenshot (127)

@jayaike
Copy link
Contributor Author

jayaike commented Jan 12, 2020

I also made all the responses into variables so changing them won't be ann issue :) @vkartik97 @Ram81 @RishabhJain2018

@pushkalkatara
Copy link

@nsjcorps Still the code coverage is decreased. Can you resolve it?

@jayaike
Copy link
Contributor Author

jayaike commented Jan 12, 2020

I mentioned the reason why the code coverage is down @pushkalkatara

@jayaike
Copy link
Contributor Author

jayaike commented Jan 12, 2020

There is a part of the function that I can not test because it never gets called which I showed above. That would be the exception raised for the MissingSchema @pushkalkatara

@jayaike
Copy link
Contributor Author

jayaike commented Jan 13, 2020

If the exception was raised in the request block of code it would be called. However, it is not raised there @pushkalkatara

@jayaike
Copy link
Contributor Author

jayaike commented Jan 13, 2020

Should I put it there so you can see?

Comment on lines 301 to 308
except requests.exceptions.MissingSchema:
echo(
style(
"\nThe Submission is yet to be evaluated.\n",
bold=True,
fg="yellow",
)
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain why have you used requests.exceptions.MissingSchema.
Going by docs,MissingSchema is for The URL schema (e.g. http or https) is missing. exception.

@jayaike
Copy link
Contributor Author

jayaike commented Jan 13, 2020

What should I use @vkartik97 ? I took it from the display submission result function. Kindly let me know your comments

@krtkvrm
Copy link
Member

krtkvrm commented Jan 13, 2020

The Aim here is to find which condition is applicable for:

The Submission is yet to be evaluated.

How about you check the status of submission data? How about status?

@jayaike
Copy link
Contributor Author

jayaike commented Jan 13, 2020

Workin on It now @vkartik97

@jayaike
Copy link
Contributor Author

jayaike commented Jan 13, 2020

Done @pushkalkatara @vkartik97

@jayaike
Copy link
Contributor Author

jayaike commented Jan 14, 2020

Done!!

Copy link
Member

@krtkvrm krtkvrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@jayaike
Copy link
Contributor Author

jayaike commented Jan 14, 2020

Thanks @vkartik97

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants