Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Progress bar for uploading a docker image using CLI #230

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix Progress bar for uploading a docker image using CLI #230

wants to merge 1 commit into from

Conversation

jayaike
Copy link
Contributor

@jayaike jayaike commented Dec 27, 2019

I have fixed the progress bar for uploading a docker image using the CLI.

I did this by using "\r" at the end and flush=True to make sure that it refreshes the CLI every time instead of continuing on a new line

@pushkalkatara @KhalidRmb @vkartik97 I can only show you how my fix works. I can't test the actual function because as described below. Docker will hang and crash my system.

Here is how it works.

Ignore the time.sleep part of it. It is just there to emulate a delayed process.

final_5e06fb714a34a00014e845c9_692445

Copy link
Member

@krtkvrm krtkvrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nsjcorps
Can you please put Screencast of the fix?

@jayaike
Copy link
Contributor Author

jayaike commented Dec 27, 2019

@vkartik97 I have issues with docker on my laptop. Can anyone else help me with this please?

@krtkvrm
Copy link
Member

krtkvrm commented Dec 27, 2019

@nsjcorps
Can you please post the issue or error here?

@jayaike
Copy link
Contributor Author

jayaike commented Dec 28, 2019

@vkartik97 @Ram81 @KhalidRmb My system can't carry the installation. The RAM is quite small. It would be highly appreciated if someone could help me review my work.

@jayaike
Copy link
Contributor Author

jayaike commented Dec 28, 2019

I can barely install docker. If I start up the server, my system will crash. I've tried. There are no other computers here for me to use.

@jayaike
Copy link
Contributor Author

jayaike commented Dec 28, 2019

@jayaike
Copy link
Contributor Author

jayaike commented Dec 28, 2019

Pushing images doesn't work on my computer. Even if it's from a cli application

@KhalidRmb
Copy link
Member

@nsjcorps What's the issue? Are you still unable to install Docker?

@jayaike
Copy link
Contributor Author

jayaike commented Dec 28, 2019

The issue is that my laptop has a very small RAM so docker doesn't work on my system. If I even attempt to start it my system is going to shut it down @KhalidRmb

@jayaike
Copy link
Contributor Author

jayaike commented Dec 28, 2019

@KhalidRmb, That is why I am requesting that someone help me test the change I made as requested by @vkartik97

@jayaike
Copy link
Contributor Author

jayaike commented Dec 28, 2019

It would be highly appreciated

@jayaike
Copy link
Contributor Author

jayaike commented Dec 28, 2019

@pushkalkatara @KhalidRmb @vkartik97 I can only show you how my fix works. I can't test the actual function

Here is how it works.

Ignore the time.sleep part of it. It is just there to emulate a delayed process.

final_5e06fb714a34a00014e845c9_692445

Copy link
Member

@krtkvrm krtkvrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@jayaike
Copy link
Contributor Author

jayaike commented Dec 28, 2019

Thank you very much

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants