Make Output Color Across The CLI Messages Consistent According To Convention #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The build seems to be failing due to your tests |
|
There are some assertion errors so I guess that needs to be resolved |
|
It seems to be coming from test_request.py |
RishabhJain2018
requested changes
Dec 26, 2019
evalai/utils/challenges.py
Outdated
| @@ -658,4 +658,4 @@ def display_leaderboard(challenge_id, phase_split_id): | |||
| attributes = results[0]["leaderboard__schema"]["labels"] | |||
| pretty_print_leaderboard_data(attributes, results) | |||
| else: | |||
| echo("Sorry, no Leaderboard results found.") | |||
| echo(style("Sorry, no Challenge Phase Splits found.", bold=True, fg="red")) | |||
There was a problem hiding this comment.
Some of the build tests are failing due to this :)
cc: @nsjcorps
|
@RishabhJain2018 , sorry about that. Fixed. Thanks a lot for pointing it out. I appreciate it |
|
I fixed all the issues from my end. Sorry about that |
|
@nsjcorps The build is still failing. You need to update the tests too with the new CLI outputs, also there are flake8 errors. Have a look here for more details. |
|
@RishabhJain2018 @pushkalkatara Please see the new, updated pull request #228 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
I used the following colors for the CLI output:
red for errors
yellow for questions
white for information responses
green for success messages
I changed it for all output messages in the EvalAI CLI