Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Table Name Validation #2046

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

NickNack2020
Copy link
Contributor

Fixes: #1951 Improve Table Name Validation

This PR aims to consolidate table name validation logic and rules into one space. We may need to apply the validation elsewhere since parts of the logic were enforced in various areas. It may not be perfect, but I hope this is better and quickly iterated.

  • Table names cannot contain spaces
  • Validate TableName is not a Cell Address
  • A Table name must be unique across all defined names regardless of if it scoped to a workbook or sheet

Technically a table name should be unique across the workbook, but I did not tackle that, as it will impact many places we copy objects around, either copying tables or worksheets. - The workbooks that do exhibit this will not end up corrupt since there is still logic to normalize table names on save.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Table name not protected against spaces
1 participant