Fixes related to shifting ranges and sorting #1658
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix sorting of differently typed values Some performance improvements (structs can be slow!)
|
@clenzmeier thanks for the contribution and sorry it took us so long to start looking at this! This is a pretty large PR aimed to solve several independent issues. May I ask you to split this in at least two parts: one for performance optimizations, the other fixing the shifting/sorting issues? Note that @igitur is currently re-working sort and your changes may be conflicting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix shifting formulas (during insert/delete/sort) [this fixes #880 and is at least a partial fix for other related issues; however, data validation shifting is still broken]
Fix shifting during sort (so that cells have their formulas shifted)
Fix sorting of differently typed values
Some performance improvements (structs can be slow!)