Implement RelationshipErrorHandler #1619
Conversation
|
v2.12.3 should be available soon with the fix. |
|
Thanks for the speedy fix, as usual, @twsouthwick |
igitur
force-pushed
the
issue249-relationshiprewriter
branch
from
cef9272
to
e8afa8e
Compare
…iption onto new line
…app.xml has changed.
igitur
force-pushed
the
issue249-relationshiprewriter
branch
from
e8afa8e
to
f76c253
Compare
igitur
force-pushed
the
issue249-relationshiprewriter
branch
4 times, most recently
from
bd90b33
to
cffc32a
Compare
|
@Pankraty Work in progress, but if you can start looking at this, it would be appreciated. |
igitur
force-pushed
the
issue249-relationshiprewriter
branch
from
cffc32a
to
6a43b5e
Compare
igitur
force-pushed
the
issue249-relationshiprewriter
branch
from
6a43b5e
to
7f57906
Compare
|
Sorry, this got lost among incoming messages. |
|
|
||
| public XLWorkbook(LoadOptions loadOptions) | ||
| { | ||
| EventTracking = loadOptions.EventTracking; |
There was a problem hiding this comment.
Do we still use EventTracking or we are keeping this for backward compatibility only? I thought, events processing was dropped long ago so maybe it's time to deprecate this flag?
There was a problem hiding this comment.
Just checked - LoadOptions.EventTracking is only set and never read.
| @@ -664,6 +664,8 @@ public XLWorkbook() | |||
| internal XLWorkbook(String file, Boolean asTemplate) | |||
| : this(new LoadOptions()) | |||
| { | |||
| if (!asTemplate) throw new NotSupportedException(); | |||
There was a problem hiding this comment.
Why don't we fallback to ordinary loading? As a user, I would expect these two calls producing identical result:
var wb = new XLWorkbook(fileName);
var wb = new XLWorkbook(fileName, asTemplate: false);
| [TestCaseSource(nameof(MalformedFiles))] | ||
| public void CanSuccessfullyLoadMalformedFilesWithRemoveMalformedHyperlinksRelationshipErrorHandlerFactory(string file) |
There was a problem hiding this comment.
Perhaps, we should also have a test checking that opening these files without RemoveMalformedHyperlinksRelationshipErrorHandlerFactory fails. If that test starts to fail one day, that will be an indicator for us that the factory is not needed anymore and we can consider removing (deprecating) it.
Fixes #249
Depends on dotnet/Open-XML-SDK#887The
RelationshipErrorHandlerrequires modifying the package. It's an implicit assumption in ClosedXML that we don't do that when we load the package. Therefore, as a workaround, when an implementation ofRelationshipErrorHandleris provided, the input stream is copied to a newMemoryStreambefore the loading continues. This enables the handler to rewrite the package as required without touching the user-supplied file or stream.