Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multiline #64094

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Fix multiline #64094

wants to merge 12 commits into from

Conversation

Volodyachan
Copy link
Contributor

@Volodyachan Volodyachan commented May 18, 2024

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Fix performance tests in #59940

Revert

Current performance:

stage   start   0.001   0.001
stage   parse   0.000   0.002
stage   before-connect  0.000   0.002
server  0       localhost       9000
stage   connect 0.000   0.002
drop    0       0.007478952407836914    DROP TABLE IF EXISTS table_PrettyCompact
stage   drop-1  0.008   0.009
stage   settings        0.012   0.021
create  0       0.031548261642456055    CREATE TABLE IF NOT EXISTS table_PrettyCompact ENGINE = File(PrettyCompact, '/dev/null') AS test.hits
stage   create  0.032   0.054
stage   sync    0.005   0.059
display-name    0       INSERT INTO table_PrettyCompact SELECT * FROM test.hits LIMIT 10000
prewarm 0       select_format.query0.prewarm0   0       0.29166078567504883
query   0       select_format.query0.run0       0       0.2708427906036377
query   0       select_format.query0.run1       0       0.26688146591186523
query   0       select_format.query0.run2       0       0.2676239013671875
query   0       select_format.query0.run3       0       0.26795506477355957
client-time     0       1.0735334111377597      1.07330322265625
profile-total   0
stage   run     1.365   1.424
drop    0       0.0046787261962890625   DROP TABLE IF EXISTS table_PrettyCompact
stage   drop-2  0.005   1.429

My performance:

stage   start   0.002   0.002
stage   parse   0.000   0.002
stage   before-connect  0.000   0.002
server  0       localhost       9000
stage   connect 0.000   0.002
drop    0       0.007586240768432617    DROP TABLE IF EXISTS table_PrettyCompact
stage   drop-1  0.008   0.010
stage   settings        0.011   0.021
create  0       0.03223872184753418     CREATE TABLE IF NOT EXISTS table_PrettyCompact ENGINE = File(PrettyCompact, '/dev/null') AS test.hits
stage   create  0.033   0.054
stage   sync    0.042   0.095
display-name    0       INSERT INTO table_PrettyCompact SELECT * FROM test.hits LIMIT 10000
prewarm 0       select_format.query0.prewarm0   0       0.30034852027893066
query   0       select_format.query0.run0       0       0.2977633476257324
query   0       select_format.query0.run1       0       0.341022253036499
query   0       select_format.query0.run2       0       0.3212151527404785
query   0       select_format.query0.run3       0       0.327146053314209
client-time     0       1.2873638784512877      1.287146806716919
profile-total   0
stage   run     1.588   1.683
drop    0       0.006052970886230469    DROP TABLE IF EXISTS table_PrettyCompact
stage   drop-2  0.006   1.689

@Algunenano @azat can you check?

…multiline-strings-in-Pretty-formats""

This reverts commit 7bcef97.
…_setting_from_multiline_strings""

This reverts commit 7e42948.
…fix-tabs-in-pretty-format""

This reverts commit 610801f.
@alexey-milovidov alexey-milovidov added the can be tested Allows running workflows for external contributors label May 18, 2024
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-not-for-changelog This PR should not be mentioned in the changelog label May 18, 2024
@robot-clickhouse-ci-2
Copy link
Contributor

robot-clickhouse-ci-2 commented May 18, 2024

This is an automated comment for commit 3eaf640 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
A SyncThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS⏳ pending
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR⏳ pending
Mergeable CheckChecks if all other necessary checks are successful❌ failure
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure
Successful checks
Check nameDescriptionStatus
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
PR CheckThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success

@Volodyachan Volodyachan marked this pull request as draft May 21, 2024 11:16
@Volodyachan Volodyachan marked this pull request as ready for review May 21, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
can be tested Allows running workflows for external contributors pr-not-for-changelog This PR should not be mentioned in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants