Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add function generateSnowflakeID #63577

Merged
merged 20 commits into from
May 26, 2024
Merged

Conversation

kazalika
Copy link
Contributor

@kazalika kazalika commented May 9, 2024

Changelog category:

  • New Feature

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Added new SQL functions generateSnowflakeID for generating Twitter-style Snowflake IDs.

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

Modify your CI run

NOTE: If your merge the PR with modified CI you MUST KNOW what you are doing
NOTE: Checked options will be applied if set before CI RunConfig/PrepareRunConfig step

Include tests (required builds will be added automatically):

  • Fast test
  • Integration Tests
  • Stateless tests
  • Stateful tests
  • Unit tests
  • Performance tests
  • All with ASAN
  • All with TSAN
  • All with Analyzer
  • All with Azure
  • Add your option here

Exclude tests:

  • Fast test
  • Integration Tests
  • Stateless tests
  • Stateful tests
  • Performance tests
  • All with ASAN
  • All with TSAN
  • All with MSAN
  • All with UBSAN
  • All with Coverage
  • All with Aarch64
  • Add your option here

Extra options:

  • do not test (only style check)
  • disable merge-commit (no merge from master before tests)
  • disable CI cache (job reuse)

Only specified batches in multi-batch jobs:

  • 1
  • 2
  • 3
  • 4

@CLAassistant
Copy link

CLAassistant commented May 9, 2024

CLA assistant check
All committers have signed the CLA.

@kazalika kazalika marked this pull request as draft May 9, 2024 16:45
@den-crane
Copy link
Contributor

@den-crane
Copy link
Contributor

#56228 (comment)

@kazalika kazalika changed the title Add serial, generateSnowflakeID, generateUUIDv7 functions Add serial, generateSnowflakeID functions May 12, 2024
@rschu1ze rschu1ze self-assigned this May 19, 2024
@robot-ch-test-poll2 robot-ch-test-poll2 added the pr-feature Pull request with new product feature label May 19, 2024
@robot-ch-test-poll2
Copy link
Contributor

robot-ch-test-poll2 commented May 19, 2024

This is an automated comment for commit 1425f07 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
A SyncThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS⏳ pending
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR⏳ pending
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests❌ failure
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts❌ failure
Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
PR CheckThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success

src/Functions/generateSnowflakeID.cpp Outdated Show resolved Hide resolved
src/Functions/generateSnowflakeID.cpp Outdated Show resolved Hide resolved
src/Functions/generateSnowflakeID.cpp Outdated Show resolved Hide resolved
src/Functions/generateSnowflakeID.cpp Outdated Show resolved Hide resolved
src/Functions/generateSnowflakeID.cpp Outdated Show resolved Hide resolved
src/Functions/serial.cpp Outdated Show resolved Hide resolved
src/Functions/serial.cpp Outdated Show resolved Hide resolved
src/Functions/serial.cpp Outdated Show resolved Hide resolved
src/Functions/serial.cpp Outdated Show resolved Hide resolved
src/Functions/serial.cpp Outdated Show resolved Hide resolved
@rschu1ze rschu1ze changed the title Add serial, generateSnowflakeID functions Add serial and generateSnowflakeID functions May 19, 2024
src/Functions/serial.cpp Outdated Show resolved Hide resolved
@rschu1ze rschu1ze changed the title Add generateSerialID and generateSnowflakeID functions Add function generateSnowflakeID May 23, 2024
@rschu1ze
Copy link
Member

@kazalika I reverted generateSerialID in reference to my comment.

Please create a new PR for generateSerialID, using a revert of the reverting commit as a starting point, thanks!

@rschu1ze rschu1ze added the can be tested Allows running workflows for external contributors label May 23, 2024
@rschu1ze rschu1ze marked this pull request as ready for review May 23, 2024 18:33
@rschu1ze

This comment was marked as resolved.

@rschu1ze

This comment was marked as resolved.

@rschu1ze rschu1ze mentioned this pull request May 24, 2024
30 tasks
@ClickHouse ClickHouse deleted a comment from pashandor789 May 24, 2024
@rschu1ze rschu1ze added this pull request to the merge queue May 26, 2024
Merged via the queue into ClickHouse:master with commit fb70f2f May 26, 2024
239 of 247 checks passed
@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-synced-to-cloud The PR is synced to the cloud repo label May 26, 2024
@alexey-milovidov
Copy link
Member

@rschu1ze, are you sure we need two functions?

Why not have a single function that acquires global monotonic increments per each block and processes a block without synchronization?

It does not matter if it does not strictly follow the spec of Snowflake ID.

But having these two functions is unnecessarily obscure and complicated for an end-user.

@rschu1ze
Copy link
Member

@alexey-milovidov The original motivation for two functions was generateUUIDv7 which comes in three forms (the "non-monotonic" variant does not make sense for snowflake ids so it was omitted).

Anyways, thinking about it, the use case for generateSnowflakeIDThreadMonotonic is indeed quite obscure. Let me remove it (--> #64499). If there is an actual need / use case, we can restore the code.

Besides that, the "normal" generateSnowflakeId works just the way you described. It acquires a global monotonic increment per block and, if this succeeds, it needs no further synchronization.

@alexey-milovidov
Copy link
Member

@rschu1ze Thank you!
Let's also re-think UUIDv7. Maybe we can get away with a single function, and it will be better UX?

@rschu1ze
Copy link
Member

rschu1ze commented May 28, 2024

@alexey-milovidov Looking at the original PR, I guess the only reason to introduce NonMonotonic and ThreadMonotonic variants for generateUUIDv7 was that performance of the standard function was not great because of locking. Besides that, I agree that these two variants lack a good use case.

Revert: #64506
I also opened #64507 for newcomers to improve the locking in generateUUIDv7.

@franz101
Copy link

franz101 commented Jun 1, 2024

@kazalika really awesome implementation, I wonder though if the API is a bit inconsistent:
#64713

snowflakeToDateTime(generateSnowflakeID()::Int64) will return 2065-04-04 23:58:22
on the other hand there is no way to pass an epoch to generateSnowflakeID(1, 1288834974)
while the snowflakeToDateTime always assumes epoch 1288834974

@den-crane
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
can be tested Allows running workflows for external contributors pr-feature Pull request with new product feature pr-synced-to-cloud The PR is synced to the cloud repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants