New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix 00002_log_and_exception_messages_formatting #61882
Conversation
This is an automated comment for commit 071a8ff with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page
Successful checks
|
One of the few times "A Sync" does not lie. |
@@ -232,7 +232,7 @@ MergeTreeDataMergerMutator::PartitionIdsHint MergeTreeDataMergerMutator::getPart | |||
if (status == SelectPartsDecision::SELECTED) | |||
res.insert(all_partition_ids[i]); | |||
else | |||
LOG_TEST(log, "Nothing to merge in partition {}: {}", all_partition_ids[i], out_disable_reason); | |||
LOG_TEST(log, "Nothing to merge in partition {}: {}", all_partition_ids[i], out_disable_reason.text); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now format_string
from out_disable_reason
is ignored here. But we discussed how can it be improved in the next PRs.
@tavplubix this will not fix this failure, right? https://s3.amazonaws.com/clickhouse-test-reports/61973/f6f826c85dd5b7bb8db16286fd10dcf441a440f7/stateless_tests__ubsan__[1_2].html |
Changelog category (leave one):
https://s3.amazonaws.com/clickhouse-test-reports/61675/e1f9e496408d57acc5dcb2808f77bf38f1e8a524/stateless_tests__coverage__[5_6].html
Modify your CI run:
NOTE: If your merge the PR with modified CI you MUST KNOW what you are doing
NOTE: Set desired options before CI starts or re-push after updates
Run only:
CI options:
Only specified batches in multi-batch jobs: