New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip more sanity checks for secondary create queries #61799
Conversation
This is an automated comment for commit 2d36f62 with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page
Successful checks
|
AST fuzzer (msan) - #42108 (comment) |
src/Databases/DatabaseOnDisk.cpp
Outdated
@@ -75,7 +75,7 @@ std::pair<String, StoragePtr> createTableFromAST( | |||
auto table_function = factory.get(table_function_ast, context); | |||
ColumnsDescription columns; | |||
if (ast_create_query.columns_list && ast_create_query.columns_list->columns) | |||
columns = InterpreterCreateQuery::getColumnsDescription(*ast_create_query.columns_list->columns, context, true, false); | |||
columns = InterpreterCreateQuery::getColumnsDescription(*ast_create_query.columns_list->columns, context, LoadingStrictnessLevel::ATTACH); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any specific reason we want to pass ATTACH
? I mean why not pass the mode
passed to createTableFromAST
function
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest all LGTM
CI is broken after enabling analyzer |
Changelog category (leave one):
Follow-up to #60159