Fix logical error in group_by_use_nulls + grouping set + analyzer + materialize/constant

[Avogar]

Changelog category (leave one):

• Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Fix logical error ''Unexpected return type from materialize. Expected Nullable. Got UInt8' while using group_by_use_nulls with analyzer and materialize/constant in grouping set. Closes #61531

Documentation entry for user-facing changes

• Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

[robot-clickhouse]

This is an automated comment for commit 5f954e7 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check name	Description	Status
AST fuzzer	Runs randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help	❌ failure
CI running	A meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR	⏳ pending
Performance Comparison	Measure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests	❌ failure
Stateful tests	Runs stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc	❌ failure
Stateless tests	Runs stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc	❌ failure

Successful checks

Check name	Description	Status
A Sync	There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS	✅ success
Bugfix validation	Checks that either a new test (functional or integration) or there some changed tests that fail with the binary built on master branch	✅ success
ClickBench	Runs [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table	✅ success
ClickHouse build check	Builds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process	✅ success
Compatibility check	Checks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help	✅ success
Docker keeper image	The check to build and optionally push the mentioned image to docker hub	✅ success
Docker server image	The check to build and optionally push the mentioned image to docker hub	✅ success
Docs check	Builds and tests the documentation	✅ success
Fast test	Normally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here	✅ success
Flaky tests	Checks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc	✅ success
Install packages	Checks that the built packages are installable in a clear environment	✅ success
Integration tests	The integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests	✅ success
Mergeable Check	Checks if all other necessary checks are successful	✅ success
PR Check	There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS	✅ success
Stress test	Runs stateless functional tests concurrently from several clients to detect concurrency-related errors	✅ success
Style check	Runs a set of checks to keep the code style clean. If some of tests failed, see the related log from the report	✅ success
Unit tests	Runs the unit tests for different release types	✅ success
Upgrade check	Runs stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts	✅ success

[novikd]

I think #59986 is a better fix.

[Avogar]

I think #59986 is a better fix.

Checked binary from that PR, It doesn't fix logical errors that this PR fixes

[Avogar]

Fuzzer found more issues with analyzer + group_by_use_nulls + grouping set . Now with optimization optimize_injective_functions_in_group_by:

:) SELECT intExp2(intExp2(number)) + 3 FROM numbers(10) GROUP BY GROUPING SETS (('str', intExp2(intExp2(number))), ('str'))

<Fatal> : Logical error: 'intExp2's argument does not match the expected data type'.

:) SELECT tuple(tuple(tuple(number))) FROM numbers(10) GROUP BY GROUPING SETS (('str', tuple(tuple(number))), ('str'))

<Fatal> : Logical error: 'Bad cast from type DB::ColumnNullable to DB::ColumnVector<unsigned long>'.

:) SELECT materialize(3) + 3 FROM numbers(10) GROUP BY GROUPING SETS (('str', materialize(materialize(3))), ('str'))

<Fatal> : Logical error: 'Unexpected return type from plus. Expected UInt16. Got Nullable'.

AFAIU when we replace injection function with it's arguments, we will make these arguments Nullable when group_by_use_nulls=1 instead of initial keys with injective functions, and it leads to unexpected Nullable columns in functions execution. I couldn't come up with a good solution, so I propose to just disable optimize_injective_functions_in_group_by optimization when group_by_use_nulls=1. Any other ideas? @novikd @KochetovNicolai

[Avogar]

Ok, if no objections, I will disable optimize_injective_functions_in_group_by optimization when group_by_use_nulls=1

[tavplubix]

AST fuzzer (tsan) - #59986 (comment)
ClickHouse special build check - riscv build was broken in master

Related failures:
AST fuzzer (ubsan) - #61783, but it looks suspicious
Stateless tests (aarch64) - the new test 03014_group_by_use_nulls_injective_functions_and_analyzer is flaky

[Avogar]

And fuzzer finds more and more bugs in analyzer + group_by_use_nulls, maybe something is complitely broken in the logic:

avogar-dev :) SELECT number, tuple(tuple(number)) FROM numbers(10) GROUP BY number, tuple(tuple(number)) WITH ROLLUP settings allow_experimental_analyzer=1, group_by_use_nulls=1

<Fatal> : Logical error: 'Bad cast from type DB::ColumnVector<unsigned long> to DB::ColumnNullable'.

And it's not caused by any optimization AFAIU

UPD: should be fixed in #61933, let's wait

[Avogar]

And one more:

avogar-dev :) SELECT ignore(toLowCardinality(number)) FROM numbers(10) GROUP BY GROUPING SETS ((ignore(toLowCardinality(number)), toLowCardinality(number))) settings allow_experimental_analyzer=1, group_by_use_nulls=1

<Fatal> : Logical error: 'Unexpected return type from ignore. Expected Nullable. Got UInt8'.

This one is caused by optimization optimize_group_by_function_keys

[Avogar]

Remaining fuzzer failures should be fixed in #61933