Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix read_rows count with external group by #61555

Merged
merged 1 commit into from Mar 21, 2024
Merged

Fix read_rows count with external group by #61555

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Processors/ISource.h
View file
Open in desktop
Expand Up @@ -44,7 +44,7 @@ class ISource : public IProcessor
void setStorageLimits(const std::shared_ptr<const StorageLimitsList> & storage_limits_) override;

/// Default implementation for all the sources.
std::optional<ReadProgress> getReadProgress() final;
std::optional<ReadProgress> getReadProgress() override;

void addTotalRowsApprox(size_t value);
void addTotalBytes(size_t value);
Expand Down
2 changes: 2 additions & 0 deletions src/Processors/Transforms/AggregatingTransform.cpp
View file
Open in desktop
Expand Up @@ -80,6 +80,8 @@ namespace
return convertToChunk(block);
}

std::optional<ReadProgress> getReadProgress() override { return std::nullopt; }

private:
TemporaryFileStream * tmp_stream;
};
Expand Down