Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update style python #60408

Merged
merged 13 commits into from Mar 7, 2024
Merged

Update style python #60408

merged 13 commits into from Mar 7, 2024

Conversation

Felixoid
Copy link
Member

Changelog category (leave one):

  • Build/Testing/Packaging Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Update python related style checkers. Continue the #50174

@Felixoid Felixoid added the do not test disable testing on pull request label Feb 26, 2024
@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-build Pull request with build/testing/packaging improvement label Feb 26, 2024
@robot-ch-test-poll1
Copy link
Contributor

robot-ch-test-poll1 commented Feb 26, 2024

This is an automated comment for commit d6325e2 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
A SyncThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
PR CheckThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
SQLTestThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool✅ success
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success
Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR⏳ pending
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests❌ failure
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors❌ failure

@Felixoid
Copy link
Member Author

@Felixoid Felixoid force-pushed the update-style-python branch 3 times, most recently from e689c54 to e819b14 Compare February 29, 2024 11:57
@Felixoid Felixoid mentioned this pull request Feb 29, 2024
@Felixoid Felixoid force-pushed the update-style-python branch 2 times, most recently from 13a9bed to 2451df5 Compare February 29, 2024 13:22
@Felixoid Felixoid force-pushed the update-style-python branch 2 times, most recently from 7c56a1f to 4bbd5ba Compare March 4, 2024 10:25
@Felixoid Felixoid marked this pull request as ready for review March 6, 2024 10:22
@Felixoid Felixoid merged commit 5e59722 into master Mar 7, 2024
233 of 244 checks passed
@Felixoid Felixoid deleted the update-style-python branch March 7, 2024 08:32
@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-synced-to-cloud The PR is synced to the cloud repo label Mar 7, 2024
@Felixoid
Copy link
Member Author

Felixoid commented Mar 8, 2024

@maxknv what do you think, can we easily identify if the style check image differs for head and merge commit?

It's following the #61105 (comment)

Then we can reliably suggest updating the branch in the report, I think.

@maxknv
Copy link
Member

maxknv commented Mar 10, 2024

such a style check update breaks CI for all open PRs that are receiving new commit.
this solution won't make people happy, I'm afraid

@Felixoid
Copy link
Member Author

I think, even if we would notify the PR about a way-to-fix, it would be an improvement. Sure, the best approach would be avoiding breaking, but I am stuck in the thinking of how to implement it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-build Pull request with build/testing/packaging improvement pr-synced-to-cloud The PR is synced to the cloud repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants