Merge pull request #64104 from ClickHouse/backport/23.8/64024

Backport #64024 to 23.8: Deserialize untrusted binary inputs in a safer way
ClickHouse · May 19, 2024 · f4f08fe · f4f08fe
2 parents 65d4535 + f555fbf
commit f4f08fe
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/src/Core/Field.cpp b/src/Core/Field.cpp
@@ -20,6 +20,7 @@ namespace ErrorCodes
 {
     extern const int CANNOT_RESTORE_FROM_FIELD_DUMP;
     extern const int DECIMAL_OVERFLOW;
+    extern const int INCORRECT_DATA;
 }
 
 inline Field getBinaryValue(UInt8 type, ReadBuffer & buf)
@@ -134,7 +135,7 @@ inline Field getBinaryValue(UInt8 type, ReadBuffer & buf)
             return bool(value);
         }
     }
-    return Field();
+    throw Exception(ErrorCodes::INCORRECT_DATA, "Unknown field type {}", std::to_string(type));
 }
 
 void readBinary(Array & x, ReadBuffer & buf)