Merge pull request #64105 from ClickHouse/backport/24.2/64024

Backport #64024 to 24.2: Deserialize untrusted binary inputs in a safer way
ClickHouse · May 19, 2024 · 854d635 · 854d635
2 parents 66cc391 + 1d02ac2
commit 854d635
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/src/Core/Field.cpp b/src/Core/Field.cpp
@@ -20,6 +20,7 @@ namespace ErrorCodes
 {
     extern const int CANNOT_RESTORE_FROM_FIELD_DUMP;
     extern const int DECIMAL_OVERFLOW;
+    extern const int INCORRECT_DATA;
 }
 
 inline Field getBinaryValue(UInt8 type, ReadBuffer & buf)
@@ -140,7 +141,7 @@ inline Field getBinaryValue(UInt8 type, ReadBuffer & buf)
         case Field::Types::CustomType:
             return Field();
     }
-    UNREACHABLE();
+    throw Exception(ErrorCodes::INCORRECT_DATA, "Unknown field type {}", std::to_string(type));
 }
 
 void readBinary(Array & x, ReadBuffer & buf)