Merge pull request #61555 from ClickHouse/fix_read_rows_count

Fix read_rows count with external group by
ClickHouse · Mar 21, 2024 · 0e4d5fa · 0e4d5fa
2 parents 9a389d7 + 9af69b4
commit 0e4d5fa
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/src/Processors/ISource.h b/src/Processors/ISource.h
@@ -44,7 +44,7 @@ class ISource : public IProcessor
     void setStorageLimits(const std::shared_ptr<const StorageLimitsList> & storage_limits_) override;
 
     /// Default implementation for all the sources.
-    std::optional<ReadProgress> getReadProgress() final;
+    std::optional<ReadProgress> getReadProgress() override;
 
     void addTotalRowsApprox(size_t value);
     void addTotalBytes(size_t value);

diff --git a/src/Processors/Transforms/AggregatingTransform.cpp b/src/Processors/Transforms/AggregatingTransform.cpp
@@ -80,6 +80,8 @@ namespace
             return convertToChunk(block);
         }
 
+        std::optional<ReadProgress> getReadProgress() override { return std::nullopt; }
+
     private:
         TemporaryFileStream * tmp_stream;
     };