Add test for conservation of kinetic energy with topography #2961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you need to change something in the Jacobian as well? |
|
Yes, I need to turn off gravity and pressure gradients in the vertical velocity tendency derivatives |
dennisYatunin
force-pushed
the
dy/kinetic_energy_test
branch
from
c8a89ed
to
598d163
Compare
dennisYatunin
force-pushed
the
dy/kinetic_energy_test
branch
from
598d163
to
693c7cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR adds a test for exact conservation of kinetic energy in the presence of topography. The test currently passes with the changes from #2960, and it would be helpful to see whether it passes without those changes.
To-do
Update the relevant Jacobian terms, and add a test that uses implicit timestepping.