Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Creatures" Lore Tab #56665

Merged
merged 4 commits into from Apr 9, 2022
Merged

"Creatures" Lore Tab #56665

merged 4 commits into from Apr 9, 2022

Conversation

dseguin
Copy link
Member

@dseguin dseguin commented Apr 8, 2022

Summary

None

Purpose of change

(inspired by #54499)

I've always wanted a cool reason to snap photos of monsters, like keeping a handy list of descriptions that I can always refer back to.

Describe the solution

2022-04-08.16-53-16.mp4

Taking a photo of a monster (or group of monsters) records it's description in the faction UI under the "Creatures" tab. The recorded monsters are listed in alphabetical order.

creatures_tab_1

Describe alternatives you've considered

  • Breaking out the lore tabs into their own "lore" UI
  • Recording lore in the diary (this was also suggested in Snippets "LORE" Tab #54499)
  • Recording creatures on sight (no photo required)

Testing

See video above. Also tested taking pictures of monster and non-monster tiles.

Additional context

This was a surprisingly easy addition

@github-actions github-actions bot added [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Apr 8, 2022
@Venera3
Copy link
Contributor

Venera3 commented Apr 8, 2022

Very nice! I'd suggest an explanatory blurb about needing to photograph mobs to record them if the list is still empty, and maybe including the mob stat readout you get from the examine window (unless those are generated per monster, not mtype).

@dseguin
Copy link
Member Author

dseguin commented Apr 8, 2022

Very nice! I'd suggest an explanatory blurb about needing to photograph mobs to record them if the list is still empty, and maybe including the mob stat readout you get from the examine window (unless those are generated per monster, not mtype).

Cheers! There's a hint about needing a photo on an empty list (you can see it in the clip in the PR description):

_( "You haven't recorded sightings of any creatures. Taking photos can be a good way to keep track of them." );

For extra monster details, there's not much else to show, I don't think. Just the health bar and current status, which aren't really mtype stuff.

@Venera3
Copy link
Contributor

Venera3 commented Apr 8, 2022

I was thinking of the monster::extended_description entries (size, senses, difficulty rating, hardcoded attacks).

@dseguin
Copy link
Member Author

dseguin commented Apr 8, 2022

Ah, ok. That I can do :P

@dseguin dseguin marked this pull request as draft April 8, 2022 08:06
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Apr 8, 2022
@haveric
Copy link
Contributor

haveric commented Apr 8, 2022

This seems related, but I think it's asking for more than what you're doing: #36479

@dseguin
Copy link
Member Author

dseguin commented Apr 8, 2022

I've updated the description to show extended information:

creatures_tab

This seems related, but I think it's asking for more than what you're doing: #36479

All great ideas, definitely more than what I'm doing here :P
But it's something to work towards.

@dseguin dseguin marked this pull request as ready for review April 8, 2022 21:01
@kevingranade kevingranade merged commit 6818e4b into CleverRaven:master Apr 9, 2022
@dseguin dseguin deleted the monster_lore branch April 9, 2022 06:00
@LucasBurrns
Copy link

Would be a nice feature to be able to "study" the taken pictures to affect hitting the weak points of the monsters

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants