Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reimplementation of the counterbar #1245

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Reimplementation of the counterbar #1245

wants to merge 13 commits into from

Conversation

andreakarasho
Copy link
Collaborator

@andreakarasho andreakarasho commented Oct 17, 2020

Got some suggestion from:
#575
#1216

qKcC2d96Uw

  • doubleclick on empty space will enable/disable resizing
  • drag & drop items over empty space to add items in sequence [replace of the awful & useless grid system]
  • auto item arrange

@SaschaKP
Copy link
Contributor

really really nice, I like it

@K4T
Copy link

K4T commented Oct 17, 2020

In my opinion, the last element should be moved to the new line earlier, when there is not enough space to show it as a whole (+5px margin right). Not like it is now - when last element is almost completely invisible.

Great feature anyway!

@andreakarasho andreakarasho changed the title implementation of new counterbar Reimplementation of the counterbar Oct 17, 2020
@andreakarasho
Copy link
Collaborator Author

In my opinion, the last element should be moved to the new line earlier, when there is not enough space to show it as a whole (+5px margin right). Not like it is now - when last element is almost completely invisible.

Great feature anyway!

qKcC2d96Uw

Pushed the fix :)

@BlackTeaOutlands
Copy link

BlackTeaOutlands commented Oct 17, 2020

  • Would be nice to be able to clone the window to pull different windows out (i.e. place some counters on the left of the screen, some ontop).

  • Also would be nice to be able to pull one slot directly and swap places for another slot in the counter bar.

  • Also having empty tiles was pretty nice I think to make it easier to get an overview (it looks like in the preview that empty slots will be gone). So maybe an option (right click) to insert an empty slot (spacer) would be nice.

@binff04
Copy link
Contributor

binff04 commented Oct 19, 2020

Awesome job @andreakarasho! I also have one suggestion in mind of how to improve this UI even further: add an ability to bind keys to the slots on the counter (action) bar.

One way may be to add a special macro action what will use (double click on) an item under the slot X, where X is the number of the slot in the counter bar. This way you can just bind keys, let's say 1, 2, 3 to slots 1, 2, 3, for example, and by pressing that or another key the macro action will check if there is a slot on the counter bar under the given number and it has an item and then it will just execute double click action for that item.

This will make the counter bar more like an action bar in World of Warcraft where you mostly don't bind keys to certain skills but rather to the slots on the action bar. IMHO this will simplify UO's keybinding/macro system a lot. Instead to binding keys to different items you will just bind keys to the slots and then you can just drag required items to desired slots and use them immediately (perfect for potions, equipping items, etc).

@broxen
Copy link
Contributor

broxen commented Mar 10, 2021

Love this improvement! Any testing I can do to help this merge into dev?

@andreakarasho andreakarasho changed the base branch from dev to main November 7, 2022 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants