Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed deleteRow method to use Upsert and added a helper class (Payl… #86

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

StokedPrune
Copy link

I modified the existing deleterow method to basically redirect to the sodaclient.Upsert method. It still takes the same parameters and returns a SodaResult.
I added another DeleteRow method that takes a list if RowId's so can do a bulk delete now. I called it DeleteRow also, to keep the changes to a minimum, not sure if better to call it DeleteRows?
I also added a helper class into Utilities "Payloadbuilder.cs" which just takes the RowId('s) and constructs into the required json format.
I didnt add any tests, not sure if any needed, and also i'm not very familiar with test frameworks.
I wrote the same logic into my application and has been working fine. See what you think
Thanks
Mick

@AppVeyorBot
Copy link

1 similar comment
@AppVeyorBot
Copy link

@coderpatros
Copy link

@thekaveman this will fix issue #85 that my organisation has been hitting. It would be great if this could be included in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants