Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement the app page components for alterations for handler (HL-1247) #2982

Merged
merged 2 commits into from May 22, 2024
Merged

feat: implement the app page components for alterations for handler (HL-1247) #2982

merged 2 commits into from May 22, 2024

Conversation

EmiliaMakelaVincit
Copy link
Collaborator

Description ✨

Includes the following features and related fixes:

  • Added cancellation fields in the alteration database model
  • Decision information box, partially shared with the applicant interface
  • Decision calculation accordion component
  • Alteration accordion component for handler with expanded details compared to those in the applicant view
  • Alteration deletion in the "received" state (similar to applicant view)
  • Alteration cancellation in the "handled" state
  • Sorting by application number in the pending alteration list view
  • Added link to the application in the pending alteration list view
  • Fixed state filter for application alteration list endpoint
  • Fixed alteration count bubble appearing in the navigation even if the number of pending alterations is zero
  • Fixed cancelled alterations showing up in the applicant interface
  • Fixed patching a handled alteration reporting an overlapping alteration with itself

@terovirtanen
Copy link
Contributor

API branch is deployed to platta: https://tet-pr2982.api.dev.hel.ninja/healthz 🚀🚀🚀

@terovirtanen
Copy link
Contributor

API branch is deployed to platta: https://helsinkilisa-pr2982.api.dev.hel.ninja/healthz 🚀🚀🚀

@terovirtanen
Copy link
Contributor

API branch is deployed to platta: https://kesaseteli-pr2982.api.dev.hel.ninja/healthz 🚀🚀🚀

@terovirtanen
Copy link
Contributor

API branch is deployed to platta: https://tet-pr2982.api.dev.hel.ninja/healthz 🚀🚀🚀

@terovirtanen
Copy link
Contributor

EMPLOYER branch is deployed to platta: https://kesaseteli-employer-pr2982.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

ADMIN branch is deployed to platta: https://tet-admin-ui-pr2982.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://tet-admin-ui-pr2982.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

APPLICANT branch is deployed to platta: https://helsinkilisa-ui-pr2982.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

API branch is deployed to platta: https://helsinkilisa-pr2982.api.dev.hel.ninja/healthz 🚀🚀🚀

@terovirtanen
Copy link
Contributor

HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr2982.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://kesaseteli-employer-pr2982.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://helsinkilisa-ui-handler-pr2982.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

TestCafe applicant result is failed for https://helsinkilisa-ui-pr2982.dev.hel.ninja 😿💢💥💥

@terovirtanen
Copy link
Contributor

HANDLER branch is deployed to platta: https://kesaseteli-handler-pr2982.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://kesaseteli-handler-pr2982.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

YOUTH branch is deployed to platta: https://tet-youth-ui-pr2982.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://tet-youth-ui-pr2982.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

YOUTH branch is deployed to platta: https://kesaseteli-youth-pr2982.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://kesaseteli-youth-pr2982.dev.hel.ninja 😆🎉🎉🎉

@EmiliaMakelaVincit EmiliaMakelaVincit force-pushed the HL-1247-alteration-handler-p2 branch 2 times, most recently from 1f11f0f to 8e48052 Compare May 8, 2024 12:06
@terovirtanen
Copy link
Contributor

API branch is deployed to platta: https://kesaseteli-pr2982.api.dev.hel.ninja/healthz 🚀🚀🚀

@terovirtanen
Copy link
Contributor

API branch is deployed to platta: https://tet-pr2982.api.dev.hel.ninja/healthz 🚀🚀🚀

@terovirtanen
Copy link
Contributor

ADMIN branch is deployed to platta: https://tet-admin-ui-pr2982.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

API branch is deployed to platta: https://helsinkilisa-pr2982.api.dev.hel.ninja/healthz 🚀🚀🚀

@terovirtanen
Copy link
Contributor

HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr2982.dev.hel.ninja 🚀🚀🚀

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 22, 2024

Quality Gate Passed Quality Gate passed for 'yjdh'

Issues
12 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 22, 2024

Quality Gate Failed Quality Gate failed for 'yjdh'

Failed conditions
33.3% Coverage on New Code (required ≥ 65%)

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 22, 2024

Quality Gate Failed Quality Gate failed for 'yjdh'

Failed conditions
B Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 22, 2024

Quality Gate Passed Quality Gate passed for 'yjdh'

Issues
37 New issues
7 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
1.4% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 22, 2024

Quality Gate Passed Quality Gate passed for 'yjdh'

Issues
15 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 22, 2024

Quality Gate Passed Quality Gate passed for 'yjdh-tet-admin'

Issues
100 New issues
2 Accepted issues

Measures
0 Security Hotspots
53.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 22, 2024

Quality Gate Passed Quality Gate passed for 'yjdh'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 22, 2024

Quality Gate Passed Quality Gate passed for 'yjdh-tet-youth'

Issues
72 New issues
1 Accepted issue

Measures
0 Security Hotspots
29.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 22, 2024

Quality Gate Passed Quality Gate passed

Issues
35 New issues
1 Accepted issue

Measures
0 Security Hotspots
71.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 22, 2024

Quality Gate Passed Quality Gate passed for 'yjdh-tet-shared'

Issues
43 New issues
1 Accepted issue

Measures
0 Security Hotspots
44.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@terovirtanen
Copy link
Contributor

API branch is deployed to platta: https://kesaseteli-pr2982.api.dev.hel.ninja/healthz 🚀🚀🚀

@terovirtanen
Copy link
Contributor

API branch is deployed to platta: https://tet-pr2982.api.dev.hel.ninja/healthz 🚀🚀🚀

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 22, 2024

Quality Gate Passed Quality Gate passed for 'yjdh'

Issues
20 New issues
0 Accepted issues

Measures
0 Security Hotspots
84.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@terovirtanen
Copy link
Contributor

EMPLOYER branch is deployed to platta: https://kesaseteli-employer-pr2982.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

ADMIN branch is deployed to platta: https://tet-admin-ui-pr2982.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

API branch is deployed to platta: https://helsinkilisa-pr2982.api.dev.hel.ninja/healthz 🚀🚀🚀

@terovirtanen
Copy link
Contributor

HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr2982.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

APPLICANT branch is deployed to platta: https://helsinkilisa-ui-pr2982.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://tet-admin-ui-pr2982.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://helsinkilisa-ui-pr2982.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://helsinkilisa-ui-handler-pr2982.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

TestCafe employer result is failed for https://kesaseteli-employer-pr2982.dev.hel.ninja 😿💢💥💥

1 similar comment
@terovirtanen
Copy link
Contributor

TestCafe employer result is failed for https://kesaseteli-employer-pr2982.dev.hel.ninja 😿💢💥💥

@terovirtanen
Copy link
Contributor

YOUTH branch is deployed to platta: https://tet-youth-ui-pr2982.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://tet-youth-ui-pr2982.dev.hel.ninja 😆🎉🎉🎉

@EmiliaMakelaVincit EmiliaMakelaVincit merged commit ffaee28 into main May 22, 2024
162 of 164 checks passed
@EmiliaMakelaVincit EmiliaMakelaVincit deleted the HL-1247-alteration-handler-p2 branch May 22, 2024 09:55
This was referenced May 22, 2024
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sirtawast sirtawast sirtawast approved these changes

@rikuke rikuke Awaiting requested review from rikuke

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@EmiliaMakelaVincit @terovirtanen @sirtawast