Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: callback endpoint for decision status #2977

Merged
merged 4 commits into from May 16, 2024
Merged

Conversation

rikuke
Copy link
Collaborator

@rikuke rikuke commented May 6, 2024

Description ✨

Ahjo Rest API has an endpoint for subscribing to updates for decisions made in Ahjo.
This PR adds a command for doing a POST request to the endpoint with the desired callback url as the JSON payload.

python manage.py subscribe_to_decisions_api

After running the command once, Ahjo should call the registered callback address with the following payload:

{
  "updatetype": "Added", // "Added" "Updated" "Removed"
  "id": "%7B123E4567-E89B-12D3-A456-426614174000%7D",
  "caseId": "HEL 2023-123456",
  "caseGuid": "{123E4567-E89B-12D3-A456-426614174000}"
}

The application is then matched with the caseId and given the a new AhjoStatus of either signed_in_ahjo (if updatetype is "Added") or removed_in_ahjo (if updatetype is "Removed"). The "Updated" updatetype is not yet used.

Issues πŸ›

Testing βš—οΈ

Screenshots πŸ“Έ

Additional notes πŸ—’οΈ

@rikuke rikuke marked this pull request as ready for review May 7, 2024 12:00
@terovirtanen
Copy link
Contributor

API branch is deployed to platta: https://helsinkilisa-pr2977.api.dev.hel.ninja/healthz πŸš€πŸš€πŸš€

@terovirtanen
Copy link
Contributor

APPLICANT branch is deployed to platta: https://helsinkilisa-ui-pr2977.dev.hel.ninja πŸš€πŸš€πŸš€

@terovirtanen
Copy link
Contributor

HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr2977.dev.hel.ninja πŸš€πŸš€πŸš€

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://helsinkilisa-ui-handler-pr2977.dev.hel.ninja πŸ˜†πŸŽ‰πŸŽ‰πŸŽ‰

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://helsinkilisa-ui-pr2977.dev.hel.ninja πŸ˜†πŸŽ‰πŸŽ‰πŸŽ‰

Copy link

sonarcloud bot commented May 16, 2024

Quality Gate Passed Quality Gate passed for 'yjdh'

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

sonarcloud bot commented May 16, 2024

Quality Gate Passed Quality Gate passed for 'yjdh'

Issues
13 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

sonarcloud bot commented May 16, 2024

Quality Gate Passed Quality Gate passed for 'yjdh'

Issues
28 New issues
7 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.8% Duplication on New Code

See analysis details on SonarCloud

Copy link

sonarcloud bot commented May 16, 2024

@terovirtanen
Copy link
Contributor

APPLICANT branch is deployed to platta: https://helsinkilisa-ui-pr2977.dev.hel.ninja πŸš€πŸš€πŸš€

@terovirtanen
Copy link
Contributor

HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr2977.dev.hel.ninja πŸš€πŸš€πŸš€

@terovirtanen
Copy link
Contributor

API branch is deployed to platta: https://helsinkilisa-pr2977.api.dev.hel.ninja/healthz πŸš€πŸš€πŸš€

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://helsinkilisa-ui-pr2977.dev.hel.ninja πŸ˜†πŸŽ‰πŸŽ‰πŸŽ‰

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://helsinkilisa-ui-handler-pr2977.dev.hel.ninja πŸ˜†πŸŽ‰πŸŽ‰πŸŽ‰

@rikuke rikuke merged commit 3e72d40 into main May 16, 2024
63 checks passed
@rikuke rikuke deleted the HL-1138-decision-state branch May 16, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants