Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: only relevant units are shown in search filter #1166

Merged
merged 1 commit into from May 17, 2024
Merged

fix: only relevant units are shown in search filter #1166

merged 1 commit into from May 17, 2024

Conversation

vincit-matu
Copy link
Contributor

🛠️ Changelog

  • add the toggle to each search so only relevant units are shown in filter

🧪 Test plan

  • Units with only seasonal and only direct reservations available aren't shown in single and seasonal searches respectively. In lieu of exhaustively checking every unit a simple test could be to see that the unit lists in the filter should be different on each of the search pages.

🎫 Tickets

  • TILA-3247
  • TILA-3248

@vincit-matu vincit-matu requested a review from joonatank May 7, 2024 13:29
joonatank
joonatank approved these changes May 8, 2024
View reviewed changes
Copy link
Contributor

@joonatank joonatank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@joonatank joonatank merged commit 297b161 into main May 17, 2024
6 checks passed
@joonatank joonatank deleted the show-only-relevant-units-in-search-filters branch May 17, 2024 08:12
@joonatank joonatank mentioned this pull request May 21, 2024
Merged
@joonatank joonatank restored the show-only-relevant-units-in-search-filters branch May 21, 2024 10:22
@joonatank joonatank mentioned this pull request May 21, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joonatank joonatank joonatank approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vincit-matu @joonatank