Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: show cancel button for ongoing (recurring) reservations #1165

Merged
merged 1 commit into from May 14, 2024
Merged

fix: show cancel button for ongoing (recurring) reservations #1165

merged 1 commit into from May 14, 2024

Conversation

vincit-matu
Copy link
Contributor

@vincit-matu vincit-matu commented May 7, 2024 •
edited

🛠️ Changelog

  • Canceling a single reservation for recurring reservations should be possible for an ongoing reservation, but not once it's over. Changed the conditions for showing the Cancel-button as specified in the ticket.

🧪 Test plan

  • The Cancel-button should be visible for an ongoing reservation, but hidden for already ended ones

🎫 Tickets

  • TILA-3253

@vincit-matu vincit-matu requested a review from joonatank May 7, 2024 12:48
@vincit-matu vincit-matu changed the title fix: don't show cancel button for ongoing (recurring) reservations fix: show cancel button for ongoing (recurring) reservations May 7, 2024
joonatank
joonatank approved these changes May 7, 2024
View reviewed changes
Copy link
Contributor

@joonatank joonatank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@vincit-matu vincit-matu force-pushed the hide-cancel-after-reservation branch from a92c688 to 6996f1c Compare May 7, 2024 12:52
@joonatank joonatank merged commit 5515830 into main May 14, 2024
6 checks passed
@joonatank joonatank deleted the hide-cancel-after-reservation branch May 14, 2024 14:34
@joonatank joonatank mentioned this pull request May 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joonatank joonatank joonatank approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vincit-matu @joonatank