Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use active reservations in reservation quota check #1164

Merged
merged 2 commits into from May 17, 2024
Merged

fix: use active reservations in reservation quota check #1164

merged 2 commits into from May 17, 2024

Conversation

vincit-matu
Copy link
Contributor

🛠️ Changelog

  • Switch to using the new numActiveUserReservations, which is up to date with active reservations. Corrects the problem where past reservations from today were considered as part of the reservation quota, altho they were in the past.

🧪 Test plan

  • Go to a reservation unit (preferrably one with a small maximum reservation quota and minimum reservation time). Make the max amount of reservations with the first one being the next possible reservation. Wait for that first reservation to pass, and note that your reservation quota is accurate, and you can make a new reservation.

🎫 Tickets

  • TILA-3236

@vincit-matu vincit-matu requested a review from joonatank May 7, 2024 12:10
joonatank
joonatank reviewed May 7, 2024
View reviewed changes
Copy link
Contributor

@joonatank joonatank left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lint warning otherwise good

@vincit-matu vincit-matu requested a review from joonatank May 7, 2024 13:00
joonatank
joonatank approved these changes May 7, 2024
View reviewed changes
Copy link
Contributor

@joonatank joonatank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@joonatank joonatank merged commit fff8fc4 into main May 17, 2024
6 checks passed
@joonatank joonatank deleted the reservation-quota-amount branch May 17, 2024 08:12
@joonatank joonatank mentioned this pull request May 21, 2024
Merged
@joonatank joonatank restored the reservation-quota-amount branch May 21, 2024 10:23
@joonatank joonatank mentioned this pull request May 21, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joonatank joonatank joonatank approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vincit-matu @joonatank