Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: check for correct user when displaying reservation #1163

Merged
merged 1 commit into from May 23, 2024
Merged

fix: check for correct user when displaying reservation #1163

merged 1 commit into from May 23, 2024

Conversation

vincit-matu
Copy link
Contributor

🛠️ Changelog

  • Checks that the viewer is the owner of the reservation, so that reservation info can't be viewed by just anyone by typing in the url

🧪 Test plan

  • Make a reservation with one user, go to its page and copy the url. Log in as another user and try to view that url.

🎫 Tickets

  • TILA-3184

@vincit-matu vincit-matu requested a review from joonatank May 7, 2024 10:51
@vincit-matu vincit-matu requested a review from joonatank May 7, 2024 11:52
joonatank
joonatank approved these changes May 8, 2024
View reviewed changes
Copy link
Contributor

@joonatank joonatank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@joonatank joonatank mentioned this pull request May 15, 2024
Merged
@joonatank joonatank merged commit a7b59ef into main May 23, 2024
6 checks passed
@joonatank joonatank deleted the reservation-check-user branch May 23, 2024 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joonatank joonatank joonatank approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vincit-matu @joonatank