Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: my units calendar now shows the reservation name with prefix #1161

Merged
merged 1 commit into from May 23, 2024
Merged

fix: my units calendar now shows the reservation name with prefix #1161

merged 1 commit into from May 23, 2024

Conversation

vincit-matu
Copy link
Contributor

@vincit-matu vincit-matu commented May 6, 2024 •
edited

🛠️ Changelog

  • the staff/behalf prefix was not showing in the calendar entries on the my units page. now they are.

🧪 Test plan

  • go to My Units, and make a reservation choosing the staff-option. The calendar entry should show "Sis. |" in front of the reservation name.

🎫 Tickets

  • TILA-3171

@vincit-matu vincit-matu requested a review from joonatank May 6, 2024 23:35
@vincit-matu vincit-matu marked this pull request as ready for review May 6, 2024 23:35
joonatank
joonatank reviewed May 7, 2024
View reviewed changes
Copy link
Contributor

@joonatank joonatank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The other calendar ReservationUnitCalendar doesn't need this?

Should we rather enforce getReserveeName to always take the TFunction (and fix the few instances that don't)?

@vincit-matu
fix: my units calendar now shows the reservation name with prefix
af80bc1 
- makes translation function a required parameter in getReserveeName
joonatank
joonatank approved these changes May 7, 2024
View reviewed changes
Copy link
Contributor

@joonatank joonatank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@joonatank joonatank merged commit c46157f into main May 23, 2024
6 checks passed
@joonatank joonatank deleted the calendar-staff-prefix branch May 23, 2024 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joonatank joonatank joonatank approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vincit-matu @joonatank