Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix quick reservation missing options #1158

Merged
merged 2 commits into from May 22, 2024
Merged

Fix quick reservation missing options #1158

merged 2 commits into from May 22, 2024

Conversation

joonatank
Copy link
Contributor

🛠️ Changelog

  • Fix (ui): remove ghost buffers from reservation calendar when no time was selected.
  • Fix (ui): show all quick reservation times.

🧪 Test plan

  • Manual testing: reservation process: calendar buffer visibility, quick reservation options.

🎫 Tickets

  • TILA-####

@joonatank
fix: quick reservation missing options
6e19d5c 
Remove chunk limit from quick reservation because it causes confusion.
@joonatank
fix: ghost buffers from reservation calendar
b44ced5
@joonatank joonatank requested a review from vincit-matu May 6, 2024 12:01
vincit-matu
vincit-matu approved these changes May 7, 2024
View reviewed changes
Copy link
Contributor

@vincit-matu vincit-matu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree on the comment about focusSlot and calendar focus being separate entities. But yeah, LGTM 👍

@joonatank joonatank merged commit 0f40d5a into main May 22, 2024
6 checks passed
@joonatank joonatank deleted the fix-quick-reservation-missing-options branch May 22, 2024 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincit-matu vincit-matu vincit-matu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@joonatank @vincit-matu