Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor remove unused exports #1149

Merged
merged 3 commits into from May 16, 2024
Merged

Refactor remove unused exports #1149

merged 3 commits into from May 16, 2024

Conversation

joonatank
Copy link
Contributor

@joonatank joonatank commented Apr 29, 2024 •
edited by jira bot

🛠️ Changelog

  • Remove unused code. Using knip to find the low hanging fruit. Could be even more aggressive but monorepo didn't work out of box with it.

🧪 Test plan

  • Automated tests / lint.

🎫 Tickets

@joonatank joonatank force-pushed the refactor-remove-unused-exports branch from 99ccdc6 to 1ac0554 Compare April 29, 2024 07:37
vincit-matu
vincit-matu approved these changes Apr 29, 2024
View reviewed changes
Copy link
Contributor

@vincit-matu vincit-matu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍

@joonatank joonatank force-pushed the refactor-remove-unused-exports branch 2 times, most recently from da4d836 to d12c929 Compare May 6, 2024 07:43
@joonatank joonatank force-pushed the refactor-remove-unused-exports branch from d12c929 to dad99d0 Compare May 13, 2024 08:14
@joonatank joonatank force-pushed the refactor-remove-unused-exports branch from dad99d0 to de8480b Compare May 16, 2024 11:53
@joonatank joonatank merged commit bd87005 into main May 16, 2024
6 checks passed
@joonatank joonatank deleted the refactor-remove-unused-exports branch May 16, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincit-matu vincit-matu vincit-matu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@joonatank @vincit-matu