Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add permission checks to application rounds #1137

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add permission checks to application rounds #1137

wants to merge 2 commits into from

Conversation

joonatank
Copy link
Contributor

@joonatank joonatank commented Apr 24, 2024 •
edited

🛠️ Changelog

  • Add: admin app permission checks for application and application-round pages.
  • Refactor: use relay query for application-round.

🧪 Test plan

  • Manual testing: application-round, allocation, and application page should correctly return permission error pages if the user doesn't have can_validate_applications or can_handle_applications.

🎫 Tickets

@joonatank joonatank force-pushed the add-permission-checks-to-application-rounds branch from ba566d5 to 1501e8b Compare April 25, 2024 12:32
Base automatically changed from fix-gql-permission-errors to main April 25, 2024 13:25
@joonatank joonatank force-pushed the add-permission-checks-to-application-rounds branch from 1501e8b to ace9f55 Compare April 29, 2024 07:33
@joonatank joonatank requested a review from vincit-matu May 3, 2024 09:02
@joonatank joonatank force-pushed the add-permission-checks-to-application-rounds branch from ace9f55 to 3fcc06a Compare May 6, 2024 07:42
@joonatank joonatank mentioned this pull request May 6, 2024
Merged
@joonatank joonatank marked this pull request as ready for review May 6, 2024 08:46
@joonatank joonatank force-pushed the add-permission-checks-to-application-rounds branch 2 times, most recently from 6c8df93 to d8090d5 Compare May 15, 2024 13:32
@joonatank joonatank force-pushed the add-permission-checks-to-application-rounds branch from d8090d5 to 25d1f2d Compare May 22, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincit-matu vincit-matu Awaiting requested review from vincit-matu

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@joonatank