Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: require exact match in event search test #387

Merged
merged 1 commit into from May 13, 2024

Conversation

jorilindell
Copy link
Contributor

@jorilindell jorilindell commented May 3, 2024

Description

The purpose for the original query is to test that 0 results is found. Current query matches also if amount of events ends with 0. e.g. 10280 tapahtumaa. Add exact parameter to avoid the issue.

@jorilindell jorilindell requested review from harriris-vincit and a team May 3, 2024 12:42
@terovirtanen
Copy link
Contributor

LINKEDCOMPONENTS-UI branch is deployed to platta: https://linkedcomponents-pr387-ui.dev.hel.ninja 🚀🚀🚀

Copy link

sonarcloud bot commented May 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@terovirtanen
Copy link
Contributor

e2e tests result is success for https://linkedcomponents-pr387-ui.dev.hel.ninja 😆🎉🎉🎉

Copy link

@harriris-vincit harriris-vincit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jorilindell jorilindell merged commit 2fd1bb0 into main May 13, 2024
20 checks passed
@jorilindell jorilindell deleted the fix/playwright_require-exact-match branch May 13, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants