Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LINK-1982, LINK-1984 | Admin page permissions #386

Merged
merged 6 commits into from May 21, 2024
Merged

LINK-1982, LINK-1984 | Admin page permissions #386

merged 6 commits into from May 21, 2024

Conversation

jorilindell
Copy link
Contributor

@jorilindell jorilindell commented May 2, 2024 •
edited by jira bot

Description

  • Display only read-only fields for keywords and keywords sets and prevent to modify them.
  • Add feature flag to enable place admin pages. Default value is false
  • Allow organization admin pages only for financial admins and superusers
  • Allow price group admin pages only for financial admins and superusers
  • Allow only admin users to see Linked Registration instructions

Closes

LINK-1982
LINK-1984

@jorilindell jorilindell force-pushed the feature/LINK-1984_admin-page-permissions branch from ec97f51 to 1975be5 Compare May 2, 2024 17:44
@terovirtanen
Copy link
Contributor

LINKEDCOMPONENTS-UI branch is deployed to platta: https://linkedcomponents-pr386-ui.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

e2e tests result is success for https://linkedcomponents-pr386-ui.dev.hel.ninja 😆🎉🎉🎉

@jorilindell jorilindell force-pushed the feature/LINK-1984_admin-page-permissions branch from 8f8f1a9 to fe5623e Compare May 3, 2024 11:01
@terovirtanen
Copy link
Contributor

LINKEDCOMPONENTS-UI branch is deployed to platta: https://linkedcomponents-pr386-ui.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

e2e tests result is failed for https://linkedcomponents-pr386-ui.dev.hel.ninja 😿💢💥💥

@jorilindell jorilindell changed the title Feature/link 1984 admin page permissions LINK-1982, LINK-1984 | Admin page permissions May 3, 2024
@jorilindell jorilindell force-pushed the feature/LINK-1984_admin-page-permissions branch from abfd18f to 7124e69 Compare May 3, 2024 11:50
@terovirtanen
Copy link
Contributor

LINKEDCOMPONENTS-UI branch is deployed to platta: https://linkedcomponents-pr386-ui.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

e2e tests result is failed for https://linkedcomponents-pr386-ui.dev.hel.ninja 😿💢💥💥

@jorilindell jorilindell marked this pull request as ready for review May 3, 2024 12:43
@jorilindell jorilindell changed the base branch from main to feat/LINK-1960_super-user-permissions May 3, 2024 12:43
@jorilindell jorilindell requested review from harriris-vincit and a team May 3, 2024 12:43
@terovirtanen
Copy link
Contributor

e2e tests result is failed for https://linkedcomponents-pr386-ui.dev.hel.ninja 😿💢💥💥

@terovirtanen
Copy link
Contributor

e2e tests result is success for https://linkedcomponents-pr386-ui.dev.hel.ninja 😆🎉🎉🎉

@jorilindell jorilindell force-pushed the feat/LINK-1960_super-user-permissions branch from 6893654 to e399abf Compare May 6, 2024 10:08
Base automatically changed from feat/LINK-1960_super-user-permissions to main May 6, 2024 11:28
@jorilindell jorilindell force-pushed the feature/LINK-1984_admin-page-permissions branch from 7124e69 to 2ccc942 Compare May 6, 2024 11:59
@terovirtanen
Copy link
Contributor

LINKEDCOMPONENTS-UI branch is deployed to platta: https://linkedcomponents-pr386-ui.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

e2e tests result is success for https://linkedcomponents-pr386-ui.dev.hel.ninja 😆🎉🎉🎉

@jorilindell jorilindell force-pushed the feature/LINK-1984_admin-page-permissions branch from 2ccc942 to 357f4d2 Compare May 13, 2024 12:51
@terovirtanen
Copy link
Contributor

LINKEDCOMPONENTS-UI branch is deployed to platta: https://linkedcomponents-pr386-ui.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

e2e tests result is success for https://linkedcomponents-pr386-ui.dev.hel.ninja 😆🎉🎉🎉

@jorilindell jorilindell force-pushed the feature/LINK-1984_admin-page-permissions branch from 357f4d2 to 1c26277 Compare May 16, 2024 09:04
@jorilindell jorilindell force-pushed the feature/LINK-1984_admin-page-permissions branch from 1c26277 to 5796b54 Compare May 16, 2024 09:25
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 16, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
3.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@terovirtanen
Copy link
Contributor

LINKEDCOMPONENTS-UI branch is deployed to platta: https://linkedcomponents-pr386-ui.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

e2e tests result is success for https://linkedcomponents-pr386-ui.dev.hel.ninja 😆🎉🎉🎉

harriris-vincit
harriris-vincit approved these changes May 20, 2024
View reviewed changes
Copy link

@harriris-vincit harriris-vincit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jorilindell jorilindell merged commit 62e2bdd into main May 21, 2024
19 of 20 checks passed
@jorilindell jorilindell deleted the feature/LINK-1984_admin-page-permissions branch May 21, 2024 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harriris-vincit harriris-vincit harriris-vincit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jorilindell @terovirtanen @harriris-vincit