Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LINK-1966 | fix vitest warnings #381

Merged
merged 5 commits into from May 13, 2024
Merged

Conversation

jorilindell
Copy link
Contributor

@jorilindell jorilindell commented Apr 25, 2024

Description

LocaleRoutes:

  • Use test specific mocks instead of having common mocks variable which contains all the mocks
  • Add missing mocks to get rid of some warnings

CreateEventPage:

  • Add missing mocks to get rid of some warnings

EditEventPage:

  • Add missing mocks to get rid of some warnings

mock HTMLCanvasElement.prototype.getContext function to solve accessibility test warnings

Note that there still are some warnings caused by the same name (Tuki - Tuki) in help page breadcrumbs. This issue will be solved in the LINK-1770 and can be ignored here.

Closes

LINK-1966

@terovirtanen
Copy link
Contributor

LINKEDCOMPONENTS-UI branch is deployed to platta: https://linkedcomponents-pr381-ui.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

e2e tests result is success for https://linkedcomponents-pr381-ui.dev.hel.ninja 😆🎉🎉🎉

@jorilindell jorilindell force-pushed the fix/LINK-1966_fix-vitest-warnings branch 2 times, most recently from f0f6759 to a4a819e Compare April 25, 2024 14:13
Use test specific mocks instead of having common mocks variable which contains all the mocks
Add missing mocks to get rid of some warnings
@jorilindell jorilindell force-pushed the fix/LINK-1966_fix-vitest-warnings branch from a4a819e to cfdf1c8 Compare April 25, 2024 14:16
@terovirtanen
Copy link
Contributor

LINKEDCOMPONENTS-UI branch is deployed to platta: https://linkedcomponents-pr381-ui.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

e2e tests result is failed for https://linkedcomponents-pr381-ui.dev.hel.ninja 😿💢💥💥

@terovirtanen
Copy link
Contributor

LINKEDCOMPONENTS-UI branch is deployed to platta: https://linkedcomponents-pr381-ui.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

e2e tests result is success for https://linkedcomponents-pr381-ui.dev.hel.ninja 😆🎉🎉🎉

Mock HTMLCanvasElement.prototype.getContext function to avoid 'not defined' console errors in axe tests
@jorilindell jorilindell marked this pull request as ready for review April 26, 2024 16:51
@jorilindell jorilindell requested review from a team and harriris-vincit April 26, 2024 16:51
@jorilindell jorilindell changed the title WIP: fix vitest warnings LINK-1966 | fix vitest warnings Apr 26, 2024
Copy link

sonarcloud bot commented Apr 26, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@terovirtanen
Copy link
Contributor

LINKEDCOMPONENTS-UI branch is deployed to platta: https://linkedcomponents-pr381-ui.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

e2e tests result is success for https://linkedcomponents-pr381-ui.dev.hel.ninja 😆🎉🎉🎉

Copy link
Contributor

@mikkojamG mikkojamG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jorilindell jorilindell merged commit 3b6d5ac into main May 13, 2024
20 checks passed
@jorilindell jorilindell deleted the fix/LINK-1966_fix-vitest-warnings branch May 13, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants