Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LINK-1948 | allow registration admin to signup to a closed registration #378

Conversation

jorilindell
Copy link
Contributor

@jorilindell jorilindell commented Apr 18, 2024

Description

Allow registration admin to signup to a closed registration in the case that there still are available seats

Closes

LINK-1948

@jorilindell jorilindell requested review from harriris-vincit and a team April 18, 2024 12:38
@terovirtanen
Copy link
Contributor

LINKEDCOMPONENTS-UI branch is deployed to platta: https://linkedcomponents-pr378-ui.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

e2e tests result is success for https://linkedcomponents-pr378-ui.dev.hel.ninja 😆🎉🎉🎉

Copy link

@harriris-vincit harriris-vincit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jorilindell The back-end changes have been merged and they allow a registration.created_by event admin and a substitute user to create signups to a closed registration in addition to registration admin and a superuser.

@jorilindell jorilindell force-pushed the feature/LINK-1948_allow-registration-user-to-signup-to-closes-registration branch from 33f19d6 to 49f3c84 Compare May 13, 2024 13:24
@jorilindell jorilindell force-pushed the feature/LINK-1948_allow-registration-user-to-signup-to-closes-registration branch from 49f3c84 to 1de08f1 Compare May 13, 2024 13:26
@jorilindell
Copy link
Contributor Author

@jorilindell The back-end changes have been merged and they allow a registration.created_by event admin and a substitute user to create signups to a closed registration in addition to registration admin and a superuser.

@harriris-vincit Modified checkCanUserSignupAfterSignupIsEnded function to allow a registration.created_by event admin and substitute user to create signups to a closed registration

@terovirtanen
Copy link
Contributor

LINKEDCOMPONENTS-UI branch is deployed to platta: https://linkedcomponents-pr378-ui.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

e2e tests result is success for https://linkedcomponents-pr378-ui.dev.hel.ninja 😆🎉🎉🎉

Copy link

sonarcloud bot commented May 13, 2024

Copy link

@harriris-vincit harriris-vincit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now

@jorilindell jorilindell merged commit d47aabb into main May 21, 2024
21 checks passed
@jorilindell jorilindell deleted the feature/LINK-1948_allow-registration-user-to-signup-to-closes-registration branch May 21, 2024 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants