Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LINK-1962 | Input field length validation #375

Merged
merged 8 commits into from May 13, 2024

Conversation

jorilindell
Copy link
Contributor

@jorilindell jorilindell commented Apr 16, 2024

Description

Validate maximum length of input fields

Closes

LINK-1962

@jorilindell jorilindell requested review from harriris-vincit and a team April 16, 2024 10:24
@terovirtanen
Copy link
Contributor

LINKEDCOMPONENTS-UI branch is deployed to platta: https://linkedcomponents-pr375-ui.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

e2e tests result is success for https://linkedcomponents-pr375-ui.dev.hel.ninja 😆🎉🎉🎉

@jorilindell jorilindell force-pushed the fix/LINK-1962_input-field-max-lengths branch from fc66fae to 738d25c Compare April 16, 2024 11:12
@terovirtanen
Copy link
Contributor

LINKEDCOMPONENTS-UI branch is deployed to platta: https://linkedcomponents-pr375-ui.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

e2e tests result is success for https://linkedcomponents-pr375-ui.dev.hel.ninja 😆🎉🎉🎉

@jorilindell jorilindell force-pushed the fix/LINK-1962_input-field-max-lengths branch from 738d25c to 8881bb7 Compare May 6, 2024 07:36
@terovirtanen
Copy link
Contributor

LINKEDCOMPONENTS-UI branch is deployed to platta: https://linkedcomponents-pr375-ui.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

e2e tests result is failed for https://linkedcomponents-pr375-ui.dev.hel.ninja 😿💢💥💥

@terovirtanen
Copy link
Contributor

e2e tests result is success for https://linkedcomponents-pr375-ui.dev.hel.ninja 😆🎉🎉🎉

@jorilindell jorilindell force-pushed the fix/LINK-1962_input-field-max-lengths branch from 8881bb7 to 4890470 Compare May 6, 2024 11:26
@jorilindell jorilindell force-pushed the fix/LINK-1962_input-field-max-lengths branch from 4890470 to c1c15e8 Compare May 6, 2024 11:34
@terovirtanen
Copy link
Contributor

LINKEDCOMPONENTS-UI branch is deployed to platta: https://linkedcomponents-pr375-ui.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

e2e tests result is failed for https://linkedcomponents-pr375-ui.dev.hel.ninja 😿💢💥💥

Copy link

sonarcloud bot commented May 6, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot
39.1% Coverage on New Code (required ≥ 65%)

See analysis details on SonarCloud

@terovirtanen
Copy link
Contributor

e2e tests result is success for https://linkedcomponents-pr375-ui.dev.hel.ninja 😆🎉🎉🎉

Copy link

@harriris-vincit harriris-vincit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jorilindell jorilindell merged commit a5bea58 into main May 13, 2024
19 of 20 checks passed
@jorilindell jorilindell deleted the fix/LINK-1962_input-field-max-lengths branch May 13, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants