Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LINK-1376 | add matomo tracker #340

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

LINK-1376 | add matomo tracker #340

wants to merge 1 commit into from

Conversation

timwessman
Copy link
Contributor

@timwessman timwessman commented Feb 21, 2024 •
edited by jira bot

Description ✨

Modify the site to use new Matomo approach

Issues 🐛

Closes 🙅‍♀️

LINK-1376:

Related 🤝

Testing ⚗️

Automated tests ⚙️️

Manual testing 👷‍♂️

Screenshots 📸

Additional notes 🗒️

@timwessman timwessman force-pushed the feature/LINK-1376-add-matomo-tracker branch from 809d9ab to a55f429 Compare February 23, 2024 13:02
@terovirtanen
Copy link
Contributor

LINKEDCOMPONENTS-UI branch is deployed to platta: https://linkedcomponents-pr340-ui.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

e2e tests result is failed for https://linkedcomponents-pr340-ui.dev.hel.ninja 😿💢💥💥

2 similar comments
@terovirtanen
Copy link
Contributor

e2e tests result is failed for https://linkedcomponents-pr340-ui.dev.hel.ninja 😿💢💥💥

@terovirtanen
Copy link
Contributor

e2e tests result is failed for https://linkedcomponents-pr340-ui.dev.hel.ninja 😿💢💥💥

@terovirtanen
Copy link
Contributor

LINKEDCOMPONENTS-UI branch is deployed to platta: https://linkedcomponents-pr340-ui.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

e2e tests result is success for https://linkedcomponents-pr340-ui.dev.hel.ninja 😆🎉🎉🎉

@timwessman timwessman force-pushed the feature/LINK-1376-add-matomo-tracker branch from b3750a7 to 0585d06 Compare February 27, 2024 12:12
@terovirtanen
Copy link
Contributor

LINKEDCOMPONENTS-UI branch is deployed to platta: https://linkedcomponents-pr340-ui.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

e2e tests result is success for https://linkedcomponents-pr340-ui.dev.hel.ninja 😆🎉🎉🎉

@timwessman timwessman force-pushed the feature/LINK-1376-add-matomo-tracker branch from 2d110ff to b07fe51 Compare March 7, 2024 12:44
@terovirtanen
Copy link
Contributor

LINKEDCOMPONENTS-UI branch is deployed to platta: https://linkedcomponents-pr340-ui.dev.hel.ninja 🚀🚀🚀

@timwessman
Copy link
Contributor Author

Fixed bug on matomo env params and changed REACT_APP_MATOMO_URL_BASE point to production Matomo. ie. now production Matomo really counts page load events

@terovirtanen
Copy link
Contributor

e2e tests result is success for https://linkedcomponents-pr340-ui.dev.hel.ninja 😆🎉🎉🎉

@mikkojamG mikkojamG self-assigned this Mar 12, 2024
mikkojamG
mikkojamG requested changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@mikkojamG mikkojamG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, seems to work as intended 🙂 I left some comments + findings from my own experience from implementing this on Tiedonohjaus and Hauki.

.env Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
pipelines/linkedcomponents-ui-review.yml Outdated Show resolved Hide resolved
src/common/components/matomoTracker/MatomoTracker.ts Outdated Show resolved Hide resolved
src/common/components/matomoTracker/constants.ts Outdated Show resolved Hide resolved
src/domain/app/App.tsx Outdated Show resolved Hide resolved
src/domain/app/App.tsx Outdated Show resolved Hide resolved
src/domain/app/App.tsx Outdated Show resolved Hide resolved
src/domain/app/App.tsx Outdated Show resolved Hide resolved
src/common/components/matomoTracker/__tests__/MatomoTracker.test.js Outdated Show resolved Hide resolved
@terovirtanen
Copy link
Contributor

LINKEDCOMPONENTS-UI branch is deployed to platta: https://linkedcomponents-pr340-ui.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

e2e tests result is success for https://linkedcomponents-pr340-ui.dev.hel.ninja 😆🎉🎉🎉

@timwessman timwessman force-pushed the feature/LINK-1376-add-matomo-tracker branch from 4068e0f to 778bab4 Compare March 18, 2024 11:11
@terovirtanen
Copy link
Contributor

LINKEDCOMPONENTS-UI branch is deployed to platta: https://linkedcomponents-pr340-ui.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

e2e tests result is success for https://linkedcomponents-pr340-ui.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

LINKEDCOMPONENTS-UI branch is deployed to platta: https://linkedcomponents-pr340-ui.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

e2e tests result is failed for https://linkedcomponents-pr340-ui.dev.hel.ninja 😿💢💥💥

@terovirtanen
Copy link
Contributor

e2e tests result is success for https://linkedcomponents-pr340-ui.dev.hel.ninja 😆🎉🎉🎉

@timwessman timwessman force-pushed the feature/LINK-1376-add-matomo-tracker branch from 49b3a94 to c1539c9 Compare March 20, 2024 07:56
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 20, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
81.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@terovirtanen
Copy link
Contributor

LINKEDCOMPONENTS-UI branch is deployed to platta: https://linkedcomponents-pr340-ui.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

e2e tests result is success for https://linkedcomponents-pr340-ui.dev.hel.ninja 😆🎉🎉🎉

@timwessman timwessman removed the request for review from jorilindell March 20, 2024 09:11
mikkojamG
mikkojamG approved these changes Mar 20, 2024
View reviewed changes
Copy link
Contributor

@mikkojamG mikkojamG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Could still prepare pipeline changes in advance before merging 🤔

jorilindell
jorilindell approved these changes Mar 28, 2024
View reviewed changes
Copy link
Contributor

@jorilindell jorilindell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorilindell jorilindell jorilindell approved these changes

@mikkojamG mikkojamG mikkojamG approved these changes

Assignees

@mikkojamG mikkojamG

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@timwessman @terovirtanen @jorilindell @mikkojamG