Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VEN-1539 Exclude internal organisations from tax #701

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

kristianjokela
Copy link
Contributor

Description ✨

Currently all prices are set with tax, and tax is calculated seperately as totalPretaxPrice and totalTaxPercentage from the original price. However, internal customers should receive their invoices without tax (as per ticket van-1539). This adds a case to price calculation that returns a pretax value for the price for internal customers.

Issues 🐛

https://helsinkisolutionoffice.atlassian.net/browse/VEN-1539

Closes 🙅‍♀️

VEN-1539:

Related 🤝

Testing ⚗️

Automated tests ⚙️️

Manual testing 👷‍♂️

Screenshots 📸

Additional notes 🗒️

@kristianjokela kristianjokela marked this pull request as draft December 7, 2022 11:29
@codecov-commenter
Copy link

codecov-commenter commented Dec 8, 2022

Codecov Report

Merging #701 (005d2bd) into master (5cc61c7) will decrease coverage by 0.01%.
The diff coverage is 84.61%.

@@            Coverage Diff             @@
##           master     #701      +/-   ##
==========================================
- Coverage   85.93%   85.91%   -0.02%     
==========================================
  Files         150      150              
  Lines        9048     9050       +2     
  Branches     1455     1456       +1     
==========================================
  Hits         7775     7775              
- Misses       1084     1085       +1     
- Partials      189      190       +1     
Impacted Files Coverage Δ
payments/utils.py 83.61% <50.00%> (-0.47%) ⬇️
payments/models.py 89.56% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kristianjokela kristianjokela marked this pull request as ready for review December 30, 2022 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants