fix(bug): Properties Panel Freeze Upon Element Deletion in Simulation Area #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for circuitverse ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #308
This issue has been resolved by removing unnecessary code that caused the properties panel to freeze when an element was deleted in the simulation area. Previously, the code was checking if the last selected element was a new element or not, and upon deletion, when the last selected element became undefined, it caused errors. By removing this portion from the showPropertiesPanel() function, the properties panel now displays project properties instead of freezing upon element deletion, improving the overall user experience.
Impact
1. The properties panel now functions smoothly even after deleting elements in the simulation area.
2. Users no longer experience freezing or unresponsiveness when interacting with the properties panel.