Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #631 : Input in truth table generator should be visible #640

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

divijsingla
Copy link

Input text in TruthTable now visible in both dark and light mode

Fixes : Earlier the text in truth table input was not visible in dark mode as the text color was being changed to white on a white background, I changed its color to black, now it is visible in both modes..

Changes done:

  • Task 1

Screenshots

Previously:
image

Now:
image

Preview Link(s): https://learn.circuitverse.org/docs/logic-design/canonical.html

✅️ By submitting this PR, I have verified the following

  • Checked to see if a similar PR has already been opened 🤔️
  • Reviewed the contributing guidelines 🔍️
  • Sample preview link added (add the link(s) for all the pages changed/updated from the checks tab after checks complete)
  • [ x] Tried Squashing the commits into one

@netlify
Copy link

netlify bot commented Feb 6, 2023

Deploy Preview for vigilant-nightingale-2f57b2 ready!

Name Link
🔨 Latest commit 4cd83ce
🔍 Latest deploy log https://app.netlify.com/sites/vigilant-nightingale-2f57b2/deploys/63e0db7a57471a0009afe802
😎 Deploy Preview https://deploy-preview-640--vigilant-nightingale-2f57b2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@Prerna-0202 Prerna-0202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm 🎉

@divijsingla
Copy link
Author

Lgtm 🎉

So when will the PR be merged?

@Harsh-1Byte
Copy link

Hey! @Prerna-0202 can I contribute as the changes are not visible on the site

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants