Added a feature to take notes using localstorage Fixes #609 #611
Conversation
|
✔️ Deploy Preview for vigilant-nightingale-2f57b2 ready! 🔨 Explore the source changes: 162e9e4 🔍 Inspect the deploy log: https://app.netlify.com/sites/vigilant-nightingale-2f57b2/deploys/61fdfe7972521d0008bd3bd6 😎 Browse the preview: https://deploy-preview-611--vigilant-nightingale-2f57b2.netlify.app |
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| font-size: unset; | ||
| } | ||
|
|
||
| #notearea { |
| display: block; | ||
| } | ||
|
|
||
| #operation button { |
There was a problem hiding this comment.
Avoid using id selectors
Merge rule #operation button with rule on line 333
| height: 34vh; | ||
| background-color: #026e57; | ||
| color: white; | ||
| } |
There was a problem hiding this comment.
I think if we can have the notes at the place where a user has selected a text that will be much helpful.
Like according to me the user end flow must be like this
user select a text -> notes button visible -> notes pad inserted at the place where user has selected the text
| } | ||
|
|
||
| #operation button { | ||
| float: right; |
There was a problem hiding this comment.
Properties should be ordered background-color, color, float, font-size, margin-right
| margin: 2%; | ||
| } | ||
|
|
||
| #operation button { |
There was a problem hiding this comment.
Avoid using id selectors
Merge rule #operation button with rule on line 331
| color: $white; | ||
| } | ||
|
|
||
| #operation { |
| } | ||
|
|
||
| .note { | ||
| display: inline-block; |
There was a problem hiding this comment.
Properties should be ordered background-color, color, display, height, margin, width
| //takenote | ||
| #takenote { | ||
| background-color: $link-color; | ||
| color: $white; |
There was a problem hiding this comment.
Properties should be ordered background-color, bottom, color, position, right
| @@ -309,3 +309,56 @@ button, | |||
| width: 0%; | |||
| z-index: 10000; | |||
| } | |||
|
|
|||
| //takenote | |||
| #takenote { | |||
yes sir @ayan-biswas0412 this is a great idea 💡 I will commit this asap |
Actually what happens in google docs commenting system, that's same i was suggesting. |
Fixes #609
Screenshots
Finally
✅️ By submitting this PR, I have verified the following