New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Corrected the karnaugh Map Table #601
base: master
Are you sure you want to change the base?
Conversation
✔️ Deploy Preview for vigilant-nightingale-2f57b2 ready! 🔨 Explore the source changes: 0584b1e 🔍 Inspect the deploy log: https://app.netlify.com/sites/vigilant-nightingale-2f57b2/deploys/61c2203f285b56000a6f241a 😎 Browse the preview: https://deploy-preview-601--vigilant-nightingale-2f57b2.netlify.app |
@manjotsidhu, Can you please review my pr once... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to implement this without needing to hardcode the tables ? The previous implementation though broken had less lines of code and was scalable.
Okay, Thanks for reviewing I will try to do it in that way... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any way to generate the numbers without hardcoding them? @Prerna-0202
It will be better if it is implemented in code to generate the values rather than hardcoding
@manjotsidhu @ayan-biswas0412, I have tried but not getting any other way to do this without hardcoding the tables...If you have any idea please share... |
@vedant-jain03 can you help @Prerna-0202 with this ? |
Yeah sure, I think we can fill the array of each by recognizing the pattern. Provide me some time for it. |
In parallel I will also try to figure out the pattern behind this |
Fixes #28
Ref #461
Changes done:
I have corrected the values in karnaugh Map table as mentioned in issue#28 for all the input values of k ...
Screenshots
Before:-
After:-
✅️ By submitting this PR, I have verified the following