Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Gif to getting_started.md #288

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mohitjaisal
Copy link

@mohitjaisal mohitjaisal commented Feb 16, 2021

Improving SEO & Page load time

Changes done:

  • I've added high-quality Demo Gifs (Converted Videos into high-quality gifs)
  • Gifs are fully optimized and compressed
  • Removed video tags from getting_started.md
  • Rename it and added -circuitverse in each gif example: drag-circuitverse and added alt with the same name (these changes are for SEO improvements)
  • Gif will increase page loading time and will be smooth and clean for users
  • It will be helpful in the future, we can add high-quality gifs with small file sizes and images that are more SEO-friendly than videos.

GIF Screenshots:

clickwire-circuitverse
ctrlclickwire-circuitverse
drag-circuitverse
multiselectionDrag-circuitverse
properties-circuitverse
test_bench-circuitverse
wire-circuitverse

Preview Link(s):

https://github.com/mohitjaisal/CircuitVerseDocs/blob/master/docs/getting_started.md

✅️ By submitting this PR, I have verified the following

  • Checked to see if a similar PR has already been opened 🤔️
  • Reviewed the contributing guidelines 🔍️
  • Sample preview link added (add a link from the checks tab after checks complete)
  • Tried Squashing the commits into one

@mohitjaisal
Copy link
Author

@Shivansh2407 Please Review!

Copy link
Member

@Shivansh2407 Shivansh2407 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mohitjaisal, Nice work done here! Just wanted to inform that we're currently transforming the Docs and #282 is the PR for the same. You can improve any of the issues you face in that, or also can enhance SEO and Page Load time for the new Docs site.
Keep Contributing 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants