Fix description of Priority Encoder Enable to 'Valid' output. #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes CircuitVerse/CircuitVerse#1702
Changes done:
This PR fixes the documentation in the online help for the Priority Encoder circuit element. A separate PR to the CircuitVerse JavaScript code will fix the labeling of the circuit element's connection.
UI change?
No UI changes per say, however the owner of https://circuitverse.org/simulator/embed/762 should update it, removing the input on the lower left, and replacing it with an output on the lower right.
Preview Link:
https://github.com/nTrfAce/CircuitVerseDocs/blob/master/docs/decodersandplexers.md
✅️ By submitting this PR, I have verified the following