Fixed redundant links issue 206 #211
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@arkokoley @satu0king @tachyons I forgot to change my git config credentials before making those commits. I am @Umoren not @ @Janetsomehow. |
YashKumarVerma
suggested changes
May 20, 2020
docs/README.md
Outdated
| @@ -1,4 +1,4 @@ | |||
| # Welcome to CircuitVerse | |||
| <h1> Welcome to CircuitVerse </h1> | |||
There was a problem hiding this comment.
hash # works fine in markdown
There was a problem hiding this comment.
Alright would change it.
There was a problem hiding this comment.
@YashKumarVerma I've reverted it in my latest commit
|
Oh i just saw it.
No issues
…On Fri, May 22, 2020 at 9:52 PM Umoren Samuel ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In docs/README.md
<#211 (comment)>
:
> @@ -1,4 +1,4 @@
-# Welcome to CircuitVerse
+<h1> Welcome to CircuitVerse </h1>
@YashKumarVerma <https://github.com/YashKumarVerma> I've reverted it in
my latest commit
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#211 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFMHS6PJE2GFL46MMKNPRO3RS3QZ7ANCNFSM4LM5ZUVA>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Describe the changes you have made
Welcome to CircuitVerselink inREADME.mdby replacing#for level 1 heading withh1.index.htmlby changing the defaultrouterMode: 'hash'torouterMode: 'history'. Apparently the name property in docsify is hashed.Screenshots of the changes (If any) - Only the home link works